Skip to content

sourcecode port to dotty #5524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexarchambault opened this issue Nov 27, 2018 · 8 comments
Closed

sourcecode port to dotty #5524

alexarchambault opened this issue Nov 27, 2018 · 8 comments
Assignees

Comments

@alexarchambault
Copy link
Contributor

PR: com-lihaoyi/sourcecode#60

@alexarchambault
Copy link
Contributor Author

alexarchambault commented Nov 27, 2018

It mostly works, but for a few issues…

@smarter
Copy link
Member

smarter commented Nov 27, 2018

!!! some lazy values, expected to be evaluated… were not!

@allanrenucci could you take a look at this? ^

@allanrenucci
Copy link
Contributor

!!! some lazy values, expected to be evaluated… were not!

Looks like #5350

@nicolasstucki
Copy link
Contributor

@alexarchambault could you add the link of the implementation and close this issue

@alexarchambault
Copy link
Contributor Author

@nicolasstucki It's here, but still misses a few features, the last two points above:

  • macro to get the arguments of ~the root context (like in def foo(a: Int, b: String)(implicit foo: Foo) with the implicit materialization of Foo backed by a macro - how can the macro get Exprs for 2 and "a" in f(2, "a")?). Prevents to have sourcecode.Args work fine.
  • macro to get the ~raw code of arguments of the root context (in def foo(s: Seq[Int])(implicit foo: Foo), with the implicit materialization of Foo backed by a macro - how can the macro get a String "(1 to 10).sum" in f((1 to 10).sum)?). Prevents to have sourcecode.Text work fine.

@alexarchambault
Copy link
Contributor Author

Or do you prefer to close the issue in spite of them?

@nicolasstucki
Copy link
Contributor

Maybe open a specific issue for it.

@alexarchambault
Copy link
Contributor Author

Done here: #5782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants