Add IDE tests that use trees from TASTY #5223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Duhemm opened this issue Oct 9, 2018 · 0 comments

Assignees

Labels

area:ide area:testing itype:meta

Contributor

Duhemm commented Oct 9, 2018

Currently, the IDE tests work as if all the sources for a test were opened in a buffer before the test starts: https://github.com/lampepfl/dotty/blob/5a07d51fc09a854f0c4d43158bc31d3f81288b5d/language-server/test/dotty/tools/languageserver/util/CodeTester.scala#L19-L22

This doesn't accurately represent how the IDE is actually going to be used and we risk missing bugs and regressions. (See for instance: #5222)

We should also have tests where the sources are not opened, but their trees are unpickled from TASTY instead.

Duhemm added area:testing area:ide itype:meta labels

Duhemm mentioned this issue

Don't check positions in findTreesMatching #5222

Merged

Duhemm self-assigned this

Duhemm closed this as completed in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment