Skip to content

testCompilation doesn't work with separate compilation anymore due to -Ytest-pickler #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
biboudis opened this issue Sep 13, 2018 · 2 comments
Closed

testCompilation doesn't work with separate compilation anymore due to -Ytest-pickler #5103

biboudis opened this issue Sep 13, 2018 · 2 comments
Labels
area:infrastructure exp:advanced

Comments

@biboudis
Copy link
Contributor

biboudis commented Sep 13, 2018 •
edited
Loading 

$ cp -r tests/pos/i4023 tests/pos/i4024
sbt> testCompilation i4023 
sbt> testCompilation i4024

First testCompilation is OK, second raises compilation/classpath error (i4023 is used for demonstration purposes). Reproduced on master on mine and @liufengyun's PC.
@biboudis
Copy link
Contributor Author

biboudis commented Sep 14, 2018 •
edited
Loading

A note at #5059 revealed that this is an issue with -Ytest-pickler and the directories that use separate compilation tests.

@allanrenucci can we afford running once with -Ytest-pickler and once without for each file that participates in a SeparateCompilationSource (because test pickler stops compilation)?

@biboudis biboudis changed the title SBT/testCompilation error testCompilation doesn't work with separate compilation anymore due to -Ytest-pickler Sep 14, 2018
@liufengyun
Copy link
Contributor

liufengyun commented Apr 15, 2019 •
edited
Loading

Fixed in #5571 -- in pickling tests, separate compilation only test the first group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:infrastructure exp:advanced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liufengyun @biboudis