Flags defined in FromStartFlags/AfterLoadFlags should not be (re)set in completers or InfoTransformers #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

3 tasks

smarter opened this issue Mar 29, 2018 · 0 comments

Labels

area:typer exp:expert itype:bug

Member

smarter commented Mar 29, 2018 •

edited

Loading

This is a follow-up on #4202:

Here are the remaining flag mutations I believe are problematic but didn't know how to fix:

Removing any of these flags from FromStartFlags/AfterLoadFlags results in cyclic reference errors, so we can't avoid the problem that way.

smarter added itype:bug area:typer exp:expert labels

smarter mentioned this issue

Do not set/reset flags that are part of FromStartFlags/AfterLoadFlags #4202

Merged

smarter mentioned this issue

Check flags that are not supposed to be mutated by completion #7427

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment