Build breakage on current master

[Blaisorblade]

On current HEAD e1365d9, sbt launchIDE fails with a compile error—full log, extract:

$ sbt clean launchIDE shell
[...]
[info] Compiling 343 Scala sources and 1 Java source to /Users/pgiarrusso/Documents/Research/Sorgenti/Dotty-stuff/dotty/compiler/../out/bootstrap/dotty-compiler-bootstrapped/scala-0.5/classes...
[error] -- Error: /Users/pgiarrusso/Documents/Research/Sorgenti/Dotty-stuff/dotty/compiler/../out/bootstrap/dotty-compiler-bootstrapped/scala-0.5/src_managed/main/scala/tools/nsc/backend/jvm/BCodeBodyBuilder.scala:1298:16
[error] 1298 |                default
[error]      |                ^^^^^^^
[error]      |                missing arguments for method default
[error] -- Error: /Users/pgiarrusso/Documents/Research/Sorgenti/Dotty-stuff/dotty/compiler/../out/bootstrap/dotty-compiler-bootstrapped/scala-0.5/src_managed/main/scala/tools/nsc/backend/jvm/BCodeBodyBuilder.scala:1301:18
[error] 1301 |        case _ => default
[error]      |                  ^^^^^^^
[error]      |                  missing arguments for method default
[error] -- Error: /Users/pgiarrusso/Documents/Research/Sorgenti/Dotty-stuff/dotty/compiler/../out/bootstrap/dotty-compiler-bootstrapped/scala-0.5/src_managed/main/scala/tools/nsc/backend/jvm/BCodeIdiomatic.scala:420:95
[error] 420 |    final def emitIF(cond: TestOp, label: asm.Label): Unit =      { jmethod.visitJumpInsn(cond.opcodeIF,     label) }
[error]     |                                                                                          ^^^^^^^^^^^^^
[error]     |                 missing arguments for method opcodeIF in class TestOp
[error] -- Error: /Users/pgiarrusso/Documents/Research/Sorgenti/Dotty-stuff/dotty/compiler/../out/bootstrap/dotty-compiler-bootstrapped/scala-0.5/src_managed/main/scala/tools/nsc/backend/jvm/BCodeIdiomatic.scala:422:95
[error] 422 |    final def emitIF_ICMP(cond: TestOp, label: asm.Label): Unit = { jmethod.visitJumpInsn(cond.opcodeIFICMP, label) }
[error]     |                                                                                          ^^^^^^^^^^^^^^^^^
[error]     |             missing arguments for method opcodeIFICMP in class TestOp
[error] four errors found
[error] (dotty-compiler-bootstrapped/compile:compileIncremental) Compilation failed

The latest merged PR #3320 was approved by continuous integration, so either the breakage was due to changes on master after approval, or to some tasks missing from CI.

[allanrenucci]

I cannot reproduce. Are you sure you have your git submodules up to date?

[Blaisorblade]

You're right, I forget it every time I try out Dotty — I'll reopen if that doesn't fix it. Apologies for the annoyance.

[Blaisorblade]

Turns out I have to install node; that doesn't seem to be documented, but I'll try to check more carefully and/or do a PR to mention this.

[Blaisorblade]

Also, launchIDE seemed to work, but its ended with the following error:

[info] Starting client: List(code, -n, --extensionDevelopmentPath=/Users/pgiarrusso/Documents/Research/Sorgenti/Dotty-stuff/dotty/vscode-dotty, /Users/pgiarrusso/Documents/Research/Sorgenti/Dotty-stuff/dotty/language-server/..)
[info] Starting server
[error] Oct 23, 2017 2:27:29 PM org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint notify
[error] INFO: Unsupported notification method: $/setTraceNotification