Skip to content

Enable all Presentation Compiler tests on the CI for PRs (including Windows tests) #20991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gedochao opened this issue Jul 3, 2024 · 3 comments · Fixed by #21626
Closed
Assignees
Labels
area:ci Issues tied with CI/CD workflows area:testing itype:meta Issues about process/similar

Comments

@Gedochao
Copy link
Contributor

Gedochao commented Jul 3, 2024

Current behaviour

PRs affecting the Presentation Compiler require the [test_windows_full] tag , which is easy to forget about, and launches suites which aren't necessary.

Expectation

PR's affecting the presentation compiler should also trigger a new job on windows that runs scala3-presentation-compiler-bootstrap/test and scala3-language-server/test when changes are made in modules mentioned above.

@Gedochao Gedochao added area:testing itype:meta Issues about process/similar area:ci Issues tied with CI/CD workflows labels Jul 3, 2024
@Gedochao
Copy link
Contributor Author

Gedochao commented Jul 3, 2024

FYI cc @hamzaremmal

@tgodzik
Copy link
Contributor

tgodzik commented Jul 3, 2024

The presentation compiler tests only broke the CI because the default tests are run on JDK 17, only the windows ones are run on JDK 8. Why is that? What is the purpose of using JDK 17, which doesn't really verify if we can compile using JDK 8?

@tgodzik
Copy link
Contributor

tgodzik commented Jul 3, 2024

Should I:

  1. windows and JDK 8 job for presentation compiler only
  2. separate JDK 8 and windows jobs for presentation compiler
  3. switch the defaults to use JDK 8 on PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Issues tied with CI/CD workflows area:testing itype:meta Issues about process/similar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants