Skip to content

Interactive compiler: go to definition for enum type param #18541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kasiaMarek opened this issue Sep 12, 2023 · 0 comments · Fixed by #18603
Closed

Interactive compiler: go to definition for enum type param #18541

kasiaMarek opened this issue Sep 12, 2023 · 0 comments · Fixed by #18603
Assignees
@rochala
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools itype:bug
Milestone
3.7.0

Comments

@kasiaMarek
Copy link
Member

kasiaMarek commented Sep 12, 2023 •
edited
Loading

Compiler version

3.4.0-RC1-bin-20230909-64c3138-NIGHTLY

Minimized code

Find definitions in interactive compiler doesn't find any results for A in MySome, since it is a distinct symbol from A in MyOption and it has zero extent.

enum MyOption[+A]:
  case MySome(value: <<A>>)
  case MyNone

Expectation

A in MyOption should be resolved as the definition.

More context

Here is a workaround in metals pc but it feels like it should be solved on a different level in the compiler, e.g. adding a span of A in MyOption to A in MySome.
@kasiaMarek kasiaMarek added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Sep 12, 2023
@mbovel mbovel added area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Sep 18, 2023
@rochala rochala mentioned this issue Sep 27, 2023
Merged
@WojciechMazur WojciechMazur added this to the 3.7.0 milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rochala rochala

Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools itype:bug
Projects
None yet
Milestone
3.7.0
Development

Successfully merging a pull request may close this issue.

Add enum type param support in sourceSymbol rochala/dotty
4 participants
@mbovel @WojciechMazur @kasiaMarek @rochala