Skip to content

Scaladoc snippet expanding and copying regression #14824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rochala opened this issue Apr 1, 2022 · 3 comments · Fixed by #14839
Closed

Scaladoc snippet expanding and copying regression #14824

rochala opened this issue Apr 1, 2022 · 3 comments · Fixed by #14839

Comments

@rochala
Copy link
Contributor

rochala commented Apr 1, 2022

Compiler version

3.1.3 - RC1

Minimized example

Scaladoc snippet copy ignores newlines when it's done via "copy" icon.
Scaladoc snippets has option to show collapsed lines with toggle button. It doesn't work right now as you can see at: https://dotty.epfl.ch/api/scala/quoted/Quotes$reflectModule$ClassDefMethods.html#body-5f

Output

image

Expectation

Snippets copying should properly include newlines.
Snippets should be expanded properly as they did in earlier versions ( this is scala 3.1.1 )
https://scala-lang.org/api/3.1.1/scala/quoted/Quotes$reflectModule$ClassDefMethods.html
image

@rochala rochala added the stat:needs triage Every issue needs to have an "area" and "itype" label label Apr 1, 2022
@KacperFKorban KacperFKorban added itype:bug area:doctool and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Apr 1, 2022
@pikinier20
Copy link
Contributor

Recently bumped highlight.js is removing .hideable class in highlighted snippets...

@KacperFKorban
Copy link
Member

@pikinier20 Is it possible to revert to the previous version of hl.js and only copy the code for (e)bnf syntax?

@pikinier20
Copy link
Contributor

I did some workaround to make the current version work properly. After few checks I'm gonna make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants