Skip to content

3.1.2 & 3.1.3-RC1 Release procedure #14731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
32 tasks done
Kordyjan opened this issue Mar 21, 2022 · 8 comments
Closed
32 tasks done

3.1.2 & 3.1.3-RC1 Release procedure #14731

Kordyjan opened this issue Mar 21, 2022 · 8 comments
Assignees
Labels
itype:meta Issues about process/similar

Comments

@Kordyjan
Copy link
Contributor

Kordyjan commented Mar 21, 2022

  • Close corresponding milestone
  • Publish 3.1.2 artifacts to Maven via CI
    • On release-3.1.2 branch
      • In Build.scala: Set baseVersion to 3.1.2
      • In Build.scala: Set previousDottyVersion to 3.1.1
      • In tasty/src/dotty/tools/tasty/TastyFormat.scala: Set ExperimentalVersion to 0 to indicate a stable release; make sure MajorVersion and MinorVersion are set correctly for the release.
      • Tag the branch as 3.1.2
    • Publish changelog for 3.1.2 on GitHub Releases
  • Publish 3.1.3-RC1 artifacts to Maven via CI
    • Create branch release-3.1.3 from master
    • On that branch
      • In tasty/src/dotty/tools/tasty/TastyFormat.scala: Set ExperimentalVersion to 0 to indicate a stable release; make sure MajorVersion and MinorVersion are set correctly for the release.
      • Tag the branch as 3.1.3-RC1
  • On master:
    • In Build.scala: Set previousDottyVersion to 3.1.2
    • In Build.scala: Set referenceVersion to 3.1.3-RC1
    • In project/MiMaFilters.scala: Remove all exclude filters
    • In Build.scala: Set baseVersion to 3.2.0-RC1
    • In tasty/src/dotty/tools/tasty/TastyFormat.scala: make sure MajorVersion and MinorVersion are set correctly for the 3.2.0.
  • Release ecosystem for 3.1.2
  • Wait for confirmation from tooling:
    • Metals
    • Scala CLI
    • Scala Native
    • SBT (support for release flags)
  • Notify Scala Steward
  • Release to SDKMAN
  • Publish API docs for 3.1.2 stdlib
  • Announce the releases
@Kordyjan Kordyjan added the itype:meta Issues about process/similar label Mar 21, 2022
@Kordyjan Kordyjan self-assigned this Mar 21, 2022
@Kordyjan
Copy link
Contributor Author

A wild blocker appeared!

Sadly we need to wait for #14736 and RC3.

@smarter
Copy link
Member

smarter commented Apr 9, 2022

In Build.scala: Set baseVersion to 3.2.0-RC1

This task list item is marked as checked, but baseVersion is currently 3.1.3-RC1 on main: https://github.com/lampepfl/dotty/blob/ebe3d54c3774bcaacad6696ccd2c444b637969b3/project/Build.scala#L62

@Kordyjan
Copy link
Contributor Author

Something went wrong. Thanks for pointing it out.

@smarter
Copy link
Member

smarter commented Apr 12, 2022

In project/MiMaFilters.scala: Remove all exclude filters

This is also checked but doesn't seem to have been done.

@Kordyjan
Copy link
Contributor Author

This is also checked but doesn't seem to have been done.

It should be rephrased as Remove all exclude filters that are no longer applicable

And it was done: 376d954#diff-66a10df3a732cc2c54a4831d5130bad719649c0cf3b4415525c657c5b73403db

@smarter
Copy link
Member

smarter commented Apr 12, 2022

When the version number ends with a ".0", mima forward compatibility checks are disabled: https://github.com/lampepfl/dotty/blob/69d2daf37f8d9835dff16e4e25200584ecec1c6f/project/Build.scala#L85-L91

It looks like you changed MiMaFilters before baseVersion was updated so that's why you couldn't remove more exclude.

@Kordyjan
Copy link
Contributor Author

Kordyjan commented Apr 12, 2022

Oh, I see. I indeed did things in reverse since it doesn't matter for patch releases.
#14915 removes all filters.

@smarter
Copy link
Member

smarter commented Apr 21, 2022

[X] Close corresponding milestone

3.1.3-RC1 wasn't closed, so I just closed it and opened 3.1.3 to track backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
itype:meta Issues about process/similar
Projects
None yet
Development

No branches or pull requests

2 participants