Skip to content

Represent summonFrom using a partial function #10624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolasstucki opened this issue Dec 3, 2020 · 3 comments
Closed

Represent summonFrom using a partial function #10624

nicolasstucki opened this issue Dec 3, 2020 · 3 comments
Assignees
@odersky
Labels
area:tasty-format issues relating to TASTy as a portable standard discussion
Milestone
3.0.0-M3

Comments

@nicolasstucki
Copy link
Contributor

Try to represent summonFrom in the compiler as as summonFrom(x => x match { case ... }).

This would mean that we would not have a special kind of Match tree in TASTy to represent it and we could remove reflect.SummonFrom.
@nicolasstucki nicolasstucki added area:metaprogramming area:tasty-format issues relating to TASTy as a portable standard labels Dec 3, 2020
@nicolasstucki nicolasstucki added this to the 3.0.0-RC1 milestone Dec 3, 2020
@nicolasstucki nicolasstucki mentioned this issue Dec 3, 2020
Closed
24 tasks
@nicolasstucki nicolasstucki modified the milestones: 3.0.0-RC1, 3.0.0-M3 Dec 3, 2020
@abgruszecki
Copy link
Contributor

During the meeting, I had the impression we aren't going to do this. Do we want to keep this issue around?

@nicolasstucki
Copy link
Contributor Author

Indeed. I wanted to confirm that tomorrow before closing it.

@nicolasstucki
Copy link
Contributor Author

We will keep the current representation in TASTy and in the reflection API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odersky odersky

Labels
area:tasty-format issues relating to TASTy as a portable standard discussion
Projects
None yet
Milestone
3.0.0-M3
Development

No branches or pull requests
4 participants
@odersky @anatoliykmetyuk @nicolasstucki @abgruszecki