Skip to content

Templates using dotty name need to be updated to scala3 #10387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolasstucki opened this issue Nov 19, 2020 · 9 comments
Closed

Templates using dotty name need to be updated to scala3 #10387

nicolasstucki opened this issue Nov 19, 2020 · 9 comments
Assignees
Milestone

Comments

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Nov 19, 2020

We still have the dotty name in dotty-example-project, dotty.g8, dotty-cross.g8, dotty-staging.g8 and dotty-tasty-inspector.g8.

They should be named scala3-example-project, scala3.g8, scala3-cross.g8, scala3-staging.g8 and scala3-tasty-inspector.g8.

Not sure if we can rename the projects without breaking the previous links. If we can't rename we can just create copies with the new names.

@SethTisue
Copy link
Member

SethTisue commented Nov 19, 2020

You are welcome to also move them to the scala organization on GitHub, if you like.

@nicolasstucki nicolasstucki added this to the 3.0.0-RC1 milestone Nov 20, 2020
@anatoliykmetyuk anatoliykmetyuk self-assigned this Nov 23, 2020
@anatoliykmetyuk
Copy link
Contributor

anatoliykmetyuk commented Nov 24, 2020

"I don't have permission to create public repos on scala", so it won't allow me to move. FTTB I'll just rename those projects.

@anatoliykmetyuk
Copy link
Contributor

Repos renamed. sbt new resolves old names correctly to the new names. Old links are also resolved correctly. I'll move them to scala upon the availability of permissions.

@SethTisue
Copy link
Member

SethTisue commented Nov 24, 2020

I sent you an invite to join https://github.com/orgs/scala/teams/admins/members , so I think that should give you the permissions you need?

@anatoliykmetyuk
Copy link
Contributor

Accepted the invite, still the same error.

@nicolasstucki
Copy link
Contributor Author

@anatoliykmetyuk did you rename those in the docs as well?

@SethTisue
Copy link
Member

SethTisue commented Nov 25, 2020

@nicolasstucki
Copy link
Contributor Author

@anatoliykmetyuk you will also need to update Travis as it stoped running tests due to the name change

@anatoliykmetyuk
Copy link
Contributor

It worked, thanks @SethTisue.
@nicolasstucki yep, need to do that all as well. I hope I'll find some time on Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants