Check for InSuperCall mode

Author: nicolasstucki

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -396,10 +396,11 @@ class Typer extends Namer
       }
       else if (name.toTermName == nme.ERROR)
         UnspecifiedErrorType
-      else if (ctx.owner.isConstructor && ctx.owner.owner.unforcedDecls.lookup(tree.name).exists) {
-        // If the field existed but was not found we assume that
-        // we where in the context of an argument of the super constructor
-        errorType(ex"$tree is not accessible from super constructor arguments", tree.pos)
+      else if (ctx.owner.isConstructor && ctx.mode.is(Mode.InSuperCall) &&
+          ctx.owner.owner.unforcedDecls.lookup(tree.name).exists) {
+        // When InSuperCall mode and in a constructor we are in the arguments
+        // of a this(...) constructor call
+        errorType(ex"$tree is not accessible from constructor arguments", tree.pos)
       } else
         errorType(new MissingIdent(tree, kind, name.show), tree.pos)
 

compiler/test-resources/repl/i2631

@@ -1,4 +1,4 @@
 scala> class Foo(x : Any) { val foo : Integer = 0; def this() = { this(foo) } }
 1 | class Foo(x : Any) { val foo : Integer = 0; def this() = { this(foo) } }
   |                                                                 ^^^
-  |                    foo is not accessible from super constructor arguments
+  |                          foo is not accessible from constructor arguments