Fix crash in compiling Dotty

Author: liufengyun

compiler/src/dotty/tools/dotc/transform/init/Checking.scala

@@ -38,7 +38,8 @@ object Checking {
     parentsInited: mutable.Set[ClassSymbol],
     safePromoted: mutable.Set[Potential],      // Potentials that can be safely promoted
     dependencies: mutable.Set[Dependency],     // if the current class is a static object, its dependencies
-    env: Env
+    env: Env,
+    init: Boolean = false                      // whether object is initialized, used in CycleChecker
   ) {
     def withOwner[T](sym: Symbol)(op: State ?=> T): T =
       val state = this.copy(env = env.withOwner(sym))
@@ -48,7 +49,7 @@ object Checking {
 
 
     def isFieldInitialized(field: Symbol): Boolean =
-      fieldsInited.contains(field)
+      init || fieldsInited.contains(field)
 
     def visit[T](eff: Effect)(op: State ?=> T): T =
       val state: State = this.copy(path = path :+ eff.source, visited = this.visited + eff)

compiler/src/dotty/tools/dotc/transform/init/CycleChecker.scala

@@ -226,7 +226,7 @@ class CycleChecker(cache: Cache) {
   }
 
   private def proxyDependencies(dep: ProxyUsage)(using Context): List[Dependency] = trace("dependencies of " + dep.symbol.show, init, _.asInstanceOf[List[Dependency]].map(_.show).toString) {
-    if (proxyCache.contains(dep.symbol)) summaryCache(dep.symbol)
+    if (proxyCache.contains(dep.symbol)) proxyCache(dep.symbol)
     else trace("summary for " + dep.symbol.show) {
       val env = Env(ctx.withOwner(dep.cls), cache)
       val state = new Checking.State(
@@ -350,24 +350,23 @@ class CycleChecker(cache: Cache) {
 
   private def analyzeMethod(dep: StaticCall)(using Context): List[Dependency] = {
     val env = Env(ctx.withOwner(dep.cls), cache)
-    val state = new Checking.State(
+    val state = Checking.State(
       visited = Set.empty,
       path = Vector.empty,
       thisClass = dep.cls,
       fieldsInited = mutable.Set.empty,
       parentsInited = mutable.Set.empty,
       safePromoted = mutable.Set(ThisRef()(dep.cls.defTree)),
       dependencies = mutable.Set.empty,
-      env = env
-    ) {
-      override def isFieldInitialized(field: Symbol): Boolean = true
-    }
+      env = env,
+      init = true
+    )
 
     val pot = Hot(dep.cls)(dep.source)
     val effs = pot.effectsOf(dep.symbol)(using env)
 
     val errs = effs.flatMap(Checking.check(_)(using state))
-    assert(errs.isEmpty, "unexpected errors: " + Errors.show(errs.toList))
+    assert(errs.isEmpty, "unexpected errors: " + Errors.show(errs.toList) + " while analyzing " + dep.show)
 
     state.dependencies.toList
   }