Merge pull request #9194 from dotty-staging/remove-seal-from-compiler-interface

Remove seal from compiler interface

Author: nicolasstucki

compiler/src/dotty/tools/dotc/tastyreflect/ReflectionCompilerInterface.scala

@@ -1901,16 +1901,6 @@ class ReflectionCompilerInterface(val rootContext: core.Contexts.Context) extend
   def QuotedType_unseal(self: scala.quoted.Type[?])(using ctx: Context): TypeTree =
     PickledQuotes.quotedTypeToTree(self)
 
-  def QuotedExpr_seal(self: Term)(using ctx: Context): Option[scala.quoted.Expr[Any]] = self.tpe.widen match {
-    case _: Types.MethodType | _: Types.PolyType => None
-    case _ => Some(new scala.internal.quoted.Expr(self, compilerId))
-  }
-
-  /** Convert `Type` to an `quoted.Type[?]` */
-  def QuotedType_seal(self: Type)(using ctx: Context): scala.quoted.Type[?] = {
-    val dummySpan = ctx.owner.span // FIXME
-    new scala.internal.quoted.Type(tpd.TypeTree(self).withSpan(dummySpan), compilerId)
-  }
 
   /////////////////
   // DEFINITIONS //

library/src/scala/tasty/Reflection.scala

@@ -621,13 +621,15 @@ class Reflection(private[scala] val internal: CompilerInterface) { self =>
 
     /** Convert `Term` to an `quoted.Expr[Any]` if the term is a valid expression or throws */
     def seal(using ctx: Context): scala.quoted.Expr[Any] =
-      internal.QuotedExpr_seal(self).getOrElse {
+      sealOpt.getOrElse {
         throw new Exception("Cannot seal a partially applied Term. Try eta-expanding the term first.")
       }
 
     /** Convert `Term` to an `quoted.Expr[Any]` if the term is a valid expression */
     def sealOpt(using ctx: Context): Option[scala.quoted.Expr[Any]] =
-      internal.QuotedExpr_seal(self)
+      self.tpe.widen match
+        case _: MethodType | _: PolyType => None
+        case _ => Some(new scala.internal.quoted.Expr(self, internal.compilerId))
 
     /** Type of this term */
     def tpe(using ctx: Context): Type = internal.Term_tpe(self)
@@ -1617,7 +1619,7 @@ class Reflection(private[scala] val internal: CompilerInterface) { self =>
 
     /** Convert `Type` to an `quoted.Type[_]` */
     def seal(using ctx: Context): scala.quoted.Type[_] =
-      internal.QuotedType_seal(self)
+      new scala.internal.quoted.Type(Inferred(self), internal.compilerId)
 
     /** Is `self` type the same as `that` type?
      *  This is the case iff `self <:< that` and `that <:< self`.

library/src/scala/tasty/reflect/CompilerInterface.scala

@@ -1446,12 +1446,6 @@ trait CompilerInterface {
   /** View this expression `quoted.Type[T]` as a `TypeTree` */
   def QuotedType_unseal(self: scala.quoted.Type[_])(using ctx: Context): TypeTree
 
-  /** Convert `Term` to an `quoted.Expr[Any]` if the term is a valid expression */
-  def QuotedExpr_seal(self: Term)(using ctx: Context): Option[scala.quoted.Expr[Any]]
-
-  /** Convert `Type` to an `quoted.Type[_]` */
-  def QuotedType_seal(self: Type)(using ctx: Context): scala.quoted.Type[_]
-
 
   /////////////////
   // DEFINITIONS //