Skip to content

Commit e827ab9

Browse files
committed
Use CompletionItemKind in CodeCompletion
1 parent e6340ad commit e827ab9

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
package dotty.tools.languageserver
22

33
import org.junit.Test
4+
import org.eclipse.lsp4j.CompletionItemKind
45

56
import dotty.tools.languageserver.util.Code._
67

78
class CompletionTest {
89

910
@Test def completion0: Unit = {
1011
code"class Foo { val xyz: Int = 0; def y: Int = xy$m1 }".withSource
11-
.completion(m1, List(("xyz", "Field", "Int")))
12+
.completion(m1, List(("xyz", CompletionItemKind.Field, "Int")))
1213
}
1314
}

language-server/test/dotty/tools/languageserver/util/CodeTester.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import dotty.tools.languageserver.util.Code.SourceWithPositions
44
import dotty.tools.languageserver.util.actions._
55
import dotty.tools.languageserver.util.embedded.CodeMarker
66
import dotty.tools.languageserver.util.server.{TestFile, TestServer}
7-
import org.eclipse.lsp4j.SymbolInformation
7+
import org.eclipse.lsp4j.CompletionItemKind
88

99
/**
1010
* Simulates an LSP client for test in a workspace defined by `sources`.
@@ -81,7 +81,7 @@ class CodeTester(sources: List[SourceWithPositions], actions: List[Action]) {
8181
*
8282
* @see dotty.tools.languageserver.util.actions.CodeCompletion
8383
*/
84-
def completion(marker: CodeMarker, expected: List[(String, String, String)]): CodeTester =
84+
def completion(marker: CodeMarker, expected: List[(String, CompletionItemKind, String)]): CodeTester =
8585
doAction(new CodeCompletion(marker, expected))
8686

8787
/**

language-server/test/dotty/tools/languageserver/util/actions/CodeCompletion.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import dotty.tools.languageserver.util.PositionContext
44
import dotty.tools.languageserver.util.embedded.CodeMarker
55
import dotty.tools.languageserver.util.server.TestFile
66

7+
import org.eclipse.lsp4j.CompletionItemKind
8+
79
import scala.collection.JavaConverters._
810

911
/**
@@ -14,7 +16,7 @@ import scala.collection.JavaConverters._
1416
* @param completions The expected results from the language server.
1517
*/
1618
class CodeCompletion(override val marker: CodeMarker,
17-
completions: List[(String, String, String)]) extends ActionOnMarker {
19+
completions: List[(String, CompletionItemKind, String)]) extends ActionOnMarker {
1820

1921
override def execute(): Exec[Unit] = {
2022
val result = server.completion(marker.toTextDocumentPositionParams).get()
@@ -24,7 +26,7 @@ class CodeCompletion(override val marker: CodeMarker,
2426
completions.foreach { completion =>
2527
assert(
2628
cList.getItems.asScala.exists(item =>
27-
completion == (item.getLabel, item.getKind.toString, item.getDetail)
29+
completion == (item.getLabel, item.getKind, item.getDetail)
2830
),
2931
"Did not return completion for " + completion + "\n" + cList.getItems.asScala.toList
3032
)

0 commit comments

Comments
 (0)