Skip to content

Commit e4e2269

Browse files
committed
Add two TODOs
1 parent 2574294 commit e4e2269

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

compiler/src/dotty/tools/dotc/typer/Checking.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -818,6 +818,7 @@ trait Checking {
818818
def checkImplicitConversionUseOK(tree: Tree)(using Context): Unit =
819819
val tree1 = if Nullables.unsafeNullsEnabled then
820820
// If unsafeNulls is enabled, a cast and a closure could be added to the original tree
821+
// !!! TODO: We need a test for that. Right now everything passes even if this case is commented out.
821822
stripCast(closureBody(tree))
822823
else tree
823824
val sym = tree1.symbol

compiler/src/dotty/tools/dotc/typer/ErrorReporting.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ object ErrorReporting {
161161
case fail: Implicits.NoMatchingImplicits => // do nothing
162162
case _ => attempts += ((failure.tree, ""))
163163
if foundWithoutNull then
164+
// !!! TODO: The need a test that tests this error message with a check file
164165
i""".
165166
|Since explicit-nulls is enabled, the selection is rejected because
166167
|${qualType.widen} could be null at runtime.

0 commit comments

Comments
 (0)