Detect more cyclic references

Detect more cyclic references be generalizing the condition which prefixes
are interesting.

Author: odersky

compiler/src/dotty/tools/dotc/typer/Checking.scala

@@ -232,7 +232,11 @@ object Checking {
           // global symbols when doing the cyclicity check.
           def isInteresting(prefix: Type): Boolean = prefix.stripTypeVar match {
             case NoPrefix => true
-            case prefix: ThisType => sym.owner.isClass && prefix.cls.isContainedIn(sym.owner)
+            case prefix: ThisType =>
+              sym.owner.isClass && (
+                prefix.cls.isContainedIn(sym.owner)    // sym reachable through outer references
+                || sym.owner.isContainedIn(prefix.cls) // sym reachable through member references
+              )
             case prefix: NamedType =>
               (!sym.is(Private) && prefix.derivesFrom(sym.owner)) ||
               (!prefix.symbol.isStaticOwner && isInteresting(prefix.prefix))
@@ -242,6 +246,7 @@ object Checking {
             case _: RefinedOrRecType | _: AppliedType => true
             case _ => false
           }
+
           if (isInteresting(pre)) {
             val pre1 = this(pre, false, false)
             if (locked.contains(tp) || tp.symbol.infoOrCompleter.isInstanceOf[NoCompleter])

tests/neg/i4368.scala

@@ -98,12 +98,12 @@ object Test6 {
 
 object Test7 {
   class Fix[F[_]] {
-    class Foo { type R >: F[T] <: F[T] }
+    class Foo { type R >: F[T] <: F[T] } // error: cyclic
     type T = F[Foo#R]
   }
 
   object App {
-    type Nat = Fix[Option]#T // error: too deep
+    type Nat = Fix[Option]#T
   }
 }
 /*