Address review comments

[Cherry-picked c93765e]

Author: odersky

compiler/src/dotty/tools/dotc/transform/SuperAccessors.scala

@@ -155,8 +155,9 @@ class SuperAccessors(thisPhase: DenotTransformer) {
 
     val needAccessor =
       name.isTermName                // Types don't need super accessors
-      && !sym.isInlineMethod && (    // Inline methods can't be overridden, don't need superaccessors
-      clazz != currentClass || !validCurrentClass || mix.name.isEmpty && clazz.is(Trait))
+      && !sym.isEffectivelyErased    // Erased and concrete inline methods are not called at runtime
+      && !sym.isInlineMethod         //   so they don't need superaccessors.
+      && (clazz != currentClass || !validCurrentClass || mix.name.isEmpty && clazz.is(Trait))
 
     if (needAccessor) atPhase(thisPhase.next)(superAccessorCall(sel, mix.name))
     else sel

tests/pos/i17584a.scala

@@ -0,0 +1,7 @@
+
+import language.experimental.erasedDefinitions
+trait A:
+  erased def g = 1
+trait B extends A:
+  erased def f = super.g
+class C extends B

tests/run/i17584.scala

@@ -7,3 +7,4 @@ class C extends B
 @main def Test =
   val c = C()
   assert(c.f == 1)
+

tests/run/i17584a.scala

@@ -0,0 +1,11 @@
+trait T:
+  def g = 2
+trait A extends T:
+  inline override def g = 1
+trait B extends A:
+  def f = super.g
+class C extends B
+
+@main def Test =
+  val c = C()
+  assert(c.f == 1)