Skip to content

Commit e04a92f

Browse files
committed
Make tests for locality of unique indices not depend on order
1 parent 6d7b9c0 commit e04a92f

File tree

6 files changed

+28
-59
lines changed

6 files changed

+28
-59
lines changed

tests/run/i2738.check

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
foo
2-
bar$2
3-
foo
4-
bar$1
5-
baz
61
Test$qux$1$
7-
baz
82
Test$qux$2$
3+
bar$1
4+
bar$2

tests/run/i2738.scala

Lines changed: 7 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,34 @@
11
object Test {
22

33
def main(args: Array[String]): Unit = {
4-
foo(1)
5-
foo("a")
6-
baz(2)
7-
baz("b")
4+
List(foo(1), foo("a"), baz(2), baz("b")).sorted.foreach(println)
85
}
96

107
def foo[X <: Int](x: X) = {
11-
def bar = printlnThisMethodName()
12-
printlnThisMethodName()
8+
def bar = thisMethodName()
139
bar
1410
}
1511

1612
def foo(x: String) = {
17-
def bar = printlnThisMethodName()
18-
printlnThisMethodName()
13+
def bar = thisMethodName()
1914
bar
2015
}
2116

2217
def baz[X <: Int](x: X) = {
2318
object qux {
24-
override def toString() = {
25-
printlnThisMethodsClassName()
26-
"a"
27-
}
19+
override def toString() = thisMethodsClassName()
2820
}
29-
printlnThisMethodName()
3021
qux.toString()
3122
}
3223

3324
def baz(x: String) = {
3425
object qux {
35-
override def toString() = {
36-
printlnThisMethodsClassName()
37-
"b"
38-
}
26+
override def toString() = thisMethodsClassName()
3927
}
40-
printlnThisMethodName()
4128
qux.toString()
4229
}
4330

44-
def printlnThisMethodName() =
45-
println(Thread.currentThread().getStackTrace()(2).getMethodName)
31+
def thisMethodName() = Thread.currentThread().getStackTrace()(2).getMethodName
4632

47-
def printlnThisMethodsClassName() =
48-
println(Thread.currentThread().getStackTrace()(2).getClassName)
33+
def thisMethodsClassName() = Thread.currentThread().getStackTrace()(2).getClassName
4934
}

tests/run/i3006.check

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
f$3
2-
f$2
31
f$1
42
f$2
3+
f$3
54
f$1
5+
f$2

tests/run/i3006.scala

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,32 @@
11
class Foo {
22
def foo() = {
3-
def f() = println(Thread.currentThread.getStackTrace.apply(1).getMethodName)
3+
def f() = Thread.currentThread.getStackTrace.apply(1).getMethodName
44
f()
55
}
66
def bar() = {
7-
def f() = println(Thread.currentThread.getStackTrace.apply(1).getMethodName)
7+
def f() = Thread.currentThread.getStackTrace.apply(1).getMethodName
88
f()
99
}
1010
def baz() = {
11-
def f() = println(Thread.currentThread.getStackTrace.apply(1).getMethodName)
11+
def f() = Thread.currentThread.getStackTrace.apply(1).getMethodName
1212
f()
1313
}
1414
}
1515

1616
class Bar {
1717
def foo() = {
18-
def f() = println(Thread.currentThread.getStackTrace.apply(1).getMethodName)
18+
def f() = Thread.currentThread.getStackTrace.apply(1).getMethodName
1919
f()
2020
}
2121
def bar() = {
22-
def f() = println(Thread.currentThread.getStackTrace.apply(1).getMethodName)
22+
def f() = Thread.currentThread.getStackTrace.apply(1).getMethodName
2323
f()
2424
}
2525
}
2626

2727
object Test {
2828
def main(args: Array[String]): Unit = {
29-
new Foo().foo()
30-
new Foo().bar()
31-
new Foo().baz()
32-
new Bar().foo()
33-
new Bar().bar()
29+
List(new Foo().foo(), new Foo().bar(), new Foo().baz()).sorted.foreach(println)
30+
List(new Bar().foo(), new Bar().bar()).sorted.foreach(println)
3431
}
3532
}

tests/run/i3006b.check

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
Foo$$init$$$bar$2
21
Foo$$init$$$bar$1
2+
Foo$$init$$$bar$2
33
Bar$$init$$$bar$1

tests/run/i3006b.scala

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,26 @@
1-
class Foo(i: Int) {
1+
class Foo(val x: String) {
2+
23
def this() = this({
3-
def bar() = {
4-
println(Thread.currentThread.getStackTrace.apply(1).getMethodName)
5-
5
6-
}
4+
def bar() = Thread.currentThread.getStackTrace.apply(1).getMethodName
75
bar()
86
})
97

10-
def this(i: String) = this({
11-
def bar() = {
12-
println(Thread.currentThread.getStackTrace.apply(1).getMethodName)
13-
5
14-
}
8+
def this(i: Int) = this({
9+
def bar() = Thread.currentThread.getStackTrace.apply(1).getMethodName
1510
bar()
1611
})
1712
}
1813

19-
class Bar(i: Int) {
14+
class Bar(val x: String) {
2015
def this() = this({
21-
def bar() = {
22-
println(Thread.currentThread.getStackTrace.apply(1).getMethodName)
23-
5
24-
}
16+
def bar() = Thread.currentThread.getStackTrace.apply(1).getMethodName
2517
bar()
2618
})
2719
}
2820

2921
object Test {
3022
def main(args: Array[String]): Unit = {
31-
new Foo()
32-
new Foo("")
33-
new Bar()
23+
List(new Foo().x, new Foo(2).x).sorted.foreach(println)
24+
println(new Bar().x)
3425
}
3526
}

0 commit comments

Comments
 (0)