Merge pull request #13870 from dotty-staging/fix-module-def-default-params-with-bridge

Fix #13860: Ignore bridges when looking for a default getter's attached method.

Author: nicolasstucki

compiler/src/dotty/tools/backend/sjs/JSCodeGen.scala

@@ -4706,7 +4706,7 @@ object JSCodeGen {
       if (!overloads.isOverloaded)
         overloads.symbol
       else
-        overloads.suchThat(_.is(HasDefaultParams)).symbol
+        overloads.suchThat(_.is(HasDefaultParams, butNot = Bridge)).symbol
     }
   }
 

tests/sjs-junit/test/org/scalajs/testsuite/compiler/RegressionTestScala3.scala

@@ -52,6 +52,13 @@ class RegressionTestScala3 {
     def intPlusString(x: String): String = 5 + x
     assertEquals("5bc", intPlusString("bc"))
   }
+
+  @Test def defaultParamsInModuleDefWithBridgesIssue13860(): Unit = {
+    import Issue13860._
+
+    assertEquals(0L, Foo.bar().x)
+    assertEquals(5L, Foo.bar(5L).x)
+  }
 }
 
 object RegressionTestScala3 {
@@ -100,6 +107,18 @@ object RegressionTestScala3 {
     import I._
     def blah = i
   }
+
+  object Issue13860 {
+    class Foo(var x: Long)
+
+    trait Companion[A] {
+      def bar(x: Long = 0): A
+    }
+
+    object Foo extends Companion[Foo] {
+      def bar(x: Long = 0): Foo = new Foo(x)
+    }
+  }
 }
 
 // This class needs to be at the top-level, not in an object, to reproduce the issue