Adress reviewers comments

Author: odersky

compiler/src/dotty/tools/dotc/core/SymDenotations.scala

@@ -135,7 +135,7 @@ object SymDenotations {
     def name = myName
 
     /** Update the name; only called when unpickling top-level classes */
-    def name_=(n: Name) = myName = n
+    protected[dotc] def name_=(n: Name) = myName = n
 
     /** The owner of the symbol; overridden in NoDenotation */
     def owner: Symbol = ownerIfExists

compiler/src/dotty/tools/dotc/core/SymbolLoaders.scala

@@ -186,12 +186,12 @@ class SymbolLoaders {
 
     private[core] val currentDecls: MutableScope = new PackageScope()
 
-    def isFlatName(name: SimpleTermName) = name.lastIndexOf('$', name.length - 2) >= 0
+    /** A name is a flat name if it contains a `$` which is not its last character */
+    def isFlatName(name: SimpleTermName) =
+      name.lastIndexOf('$', name.length - 2) >= 0
 
-    def isFlatName(classRep: ClassPath#ClassRep) = {
-      val idx = classRep.name.indexOf('$')
-      idx >= 0 && idx < classRep.name.length - 1
-    }
+    def isFlatName(classRep: ClassPath#ClassRep) =
+      classRep.name.lastIndexOf('$', classRep.name.length - 2) >= 0
 
     def maybeModuleClass(classRep: ClassPath#ClassRep) = classRep.name.last == '$'