Apply suggestions from code review for bean properties accessors

Co-authored-by: Guillaume Martres <[email protected]>

Author: Kordyjan

compiler/src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala

@@ -590,7 +590,7 @@ class TreeUnpickler(reader: TastyReader,
       val isScala2MacroDefinedInScala3 = flags.is(Macro, butNot = Inline) && flags.is(Erased)
       ctx.owner match {
         case cls: ClassSymbol if (!isScala2MacroDefinedInScala3 || cls == defn.StringContextClass) && !isSyntheticBeanAccessor  =>
-          // Enter all members of classes that are not Scala 2 macros or synthetic accessors.
+          // Enter all members of classes that are not Scala 2 macros or synthetic bean accessors.
           //
           // For `StringContext`, enter `s`, `f` and `raw`
           // These definitions will be entered when defined in Scala 2. It is fine to enter them

compiler/src/dotty/tools/dotc/transform/BeanProperties.scala

@@ -45,7 +45,7 @@ class BeanProperties(thisPhase: DenotTransformer):
         val meth = newSymbol(
           owner,
           name = prefixedName("set", valDef.name),
-          flags = Method | Permanent | Synthetic,
+          flags = Method | Synthetic,
           info = MethodType(valDef.name :: Nil, valDef.denot.info :: Nil, defn.UnitType),
           coord = annot.tree.span
         ).enteredAfter(thisPhase).asTerm