Skip to content

Commit d17e041

Browse files
authored
Merge pull request #5790 from dotty-staging/cherry-pick
Don't run Ycheck for phases that do not transform trees
2 parents 450a6a8 + 64f8a61 commit d17e041

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

compiler/src/dotty/tools/dotc/sbt/ExtractAPI.scala

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ class ExtractAPI extends Phase {
4646
super.isRunnable && (ctx.sbtCallback != null || forceRun)
4747
}
4848

49+
// Check no needed. Does not transform trees
50+
override def isCheckable: Boolean = false
51+
4952
// SuperAccessors need to be part of the API (see the scripted test
5053
// `trait-super` for an example where this matters), this is only the case
5154
// after `PostTyper` (unlike `ExtractDependencies`, the simplication to trees

compiler/src/dotty/tools/dotc/sbt/ExtractDependencies.scala

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ class ExtractDependencies extends Phase {
5454
super.isRunnable && (ctx.sbtCallback != null || forceRun)
5555
}
5656

57+
// Check no needed. Does not transform trees
58+
override def isCheckable: Boolean = false
59+
5760
// This phase should be run directly after `Frontend`, if it is run after
5861
// `PostTyper`, some dependencies will be lost because trees get simplified.
5962
// See the scripted test `constants` for an example where this matters.

compiler/src/dotty/tools/dotc/transform/SetRootTree.scala

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ class SetRootTree extends Phase {
1212
override def isRunnable(implicit ctx: Context) =
1313
super.isRunnable && ctx.settings.YretainTrees.value
1414

15+
// Check no needed. Does not transform trees
16+
override def isCheckable: Boolean = false
17+
1518
override def run(implicit ctx: Context): Unit = {
1619
val tree = ctx.compilationUnit.tpdTree
1720
traverser.traverse(tree)

0 commit comments

Comments
 (0)