Skip to content

Commit ca65933

Browse files
committed
Replace useless @serialversionuid error by a warning
akka has this annotations on some traits and cannot remove it without breaking binary-compatibility on 2.12, they worked around this error by using a compiler plugin, but we can just downgrade the error to warning so they don't have to keep doing something that horrifying.
1 parent 75edcf8 commit ca65933

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

compiler/src/dotty/tools/backend/jvm/BCodeSkelBuilder.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ trait BCodeSkelBuilder extends BCodeHelpers {
206206
val optSerial: Option[Long] =
207207
claszSymbol.getAnnotation(defn.SerialVersionUIDAnnot).flatMap { annot =>
208208
if (claszSymbol.is(Trait)) {
209-
report.error("@SerialVersionUID does nothing on a trait", annot.tree.sourcePos)
209+
report.warning("@SerialVersionUID does nothing on a trait", annot.tree.sourcePos)
210210
None
211211
} else {
212212
val vuid = annot.argumentConstant(0).map(_.longValue)

0 commit comments

Comments
 (0)