Skip to content

Commit c8e18a3

Browse files
authored
Merge pull request #4530 from snadorp/fix/repeatedEnum
Fix compiler crash for repeated Enums
2 parents a04d426 + 8cd413f commit c8e18a3

File tree

4 files changed

+36
-4
lines changed

4 files changed

+36
-4
lines changed

compiler/src/dotty/tools/dotc/ast/DesugarEnums.scala

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@ object DesugarEnums {
6464
}
6565

6666
/** A type tree referring to `enumClass` */
67-
def enumClassRef(implicit ctx: Context) = TypeTree(enumClass.typeRef)
67+
def enumClassRef(implicit ctx: Context) =
68+
if (enumClass.exists) TypeTree(enumClass.typeRef) else TypeTree()
6869

6970
/** Add implied flags to an enum class or an enum case */
7071
def addEnumFlags(cdef: TypeDef)(implicit ctx: Context) =
@@ -89,7 +90,7 @@ object DesugarEnums {
8990
DefDef(name.toTermName, Nil, Nil, TypeTree(), valuesDot(select))
9091
val privateValuesDef =
9192
ValDef(nme.DOLLAR_VALUES, TypeTree(),
92-
New(TypeTree(defn.EnumValuesType.appliedTo(enumClass.typeRef :: Nil)), ListOfNil))
93+
New(TypeTree(defn.EnumValuesType.appliedTo(enumClass.typeRef :: Nil)), ListOfNil))
9394
.withFlags(Private)
9495
val valueOfDef = enumDefDef("enumValue", "fromInt")
9596
val withNameDef = enumDefDef("enumValueNamed", "fromName")
@@ -195,7 +196,8 @@ object DesugarEnums {
195196
/** Expand a module definition representing a parameterless enum case */
196197
def expandEnumModule(name: TermName, impl: Template, mods: Modifiers, pos: Position)(implicit ctx: Context): Tree = {
197198
assert(impl.body.isEmpty)
198-
if (impl.parents.isEmpty)
199+
if (!enumClass.exists) EmptyTree
200+
else if (impl.parents.isEmpty)
199201
expandSimpleEnumCase(name, mods, pos)
200202
else {
201203
def toStringMeth =
@@ -210,7 +212,8 @@ object DesugarEnums {
210212

211213
/** Expand a simple enum case */
212214
def expandSimpleEnumCase(name: TermName, mods: Modifiers, pos: Position)(implicit ctx: Context): Tree =
213-
if (enumClass.typeParams.nonEmpty) {
215+
if (!enumClass.exists) EmptyTree
216+
else if (enumClass.typeParams.nonEmpty) {
214217
val parent = interpolatedEnumParent(pos)
215218
val impl = Template(emptyConstructor, parent :: Nil, EmptyValDef, Nil)
216219
expandEnumModule(name, impl, mods, pos)

tests/neg/i4470a.scala

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
object RepeatedEnum {
2+
3+
enum Maybe { // error // error
4+
case Foo
5+
}
6+
7+
enum Maybe { // error
8+
case Foo
9+
}
10+
}

tests/neg/i4470b.scala

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
object RepeatedExtendEnum {
2+
3+
enum Maybe[T] { // error // error
4+
case Foo extends Maybe[Int]
5+
}
6+
7+
enum Maybe[T] { // error
8+
case Foo extends Maybe[Int]
9+
}
10+
}

tests/neg/i4470c.scala

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
object DuplicatedEnum {
2+
enum Maybe[+T] { // error // error
3+
case Some(x: T)
4+
}
5+
6+
enum Maybe[+T] { // error
7+
case Some(x: T)
8+
}
9+
}

0 commit comments

Comments
 (0)