Merge branch 'lampepfl:main' into feature/linter/unused

Author: PaulCoral

.github/workflows/ci.yaml

@@ -2,13 +2,9 @@ name: Dotty
 
 on:
   push:
-    branches-ignore:
-      - 'language-reference-stable'
     tags:
       - '**'
   pull_request:
-    branches-ignore:
-      - 'language-reference-stable'
   schedule:
     - cron: '0 3 * * *'  # Every day at 3 AM
   workflow_dispatch:
@@ -256,6 +252,7 @@ jobs:
            github.event_name == 'pull_request'
            && !contains(github.event.pull_request.body, '[skip ci]')
            && !contains(github.event.pull_request.body, '[skip community_build]')
+           && !contains(github.event.pull_request.body, '[skip community_build_a]')
          )
          || (
            github.event_name == 'workflow_dispatch'
@@ -303,6 +300,7 @@ jobs:
            github.event_name == 'pull_request'
            && !contains(github.event.pull_request.body, '[skip ci]')
            && !contains(github.event.pull_request.body, '[skip community_build]')
+           && !contains(github.event.pull_request.body, '[skip community_build_b]')
          )
          || (
            github.event_name == 'workflow_dispatch'
@@ -350,6 +348,7 @@ jobs:
            github.event_name == 'pull_request'
            && !contains(github.event.pull_request.body, '[skip ci]')
            && !contains(github.event.pull_request.body, '[skip community_build]')
+           && !contains(github.event.pull_request.body, '[skip community_build_c]')
          )
          || (
            github.event_name == 'workflow_dispatch'

.github/workflows/cla.yml

@@ -1,9 +1,11 @@
 name: Scala CLA
 on:
   pull_request:
+    branches-ignore:
+      - 'language-reference-stable'
   push:
     branches:
-      - 'language-reference-backport'
+      - 'language-reference-stable'
 permissions:
   contents: write
   pull-requests: write

.github/workflows/language-reference.yaml

@@ -1,4 +1,4 @@
-name: language-reference-documentation
+name: Language reference documentation
 
 on:
   push:
@@ -14,14 +14,14 @@ permissions:
 
 jobs:
   build-and-push:
+    name: Build reference documentation and push it
     permissions:
       contents: write  # for Git to git push
-      pull-requests: write  # for peter-evans/create-pull-request to create a PR
     runs-on: ubuntu-latest
     steps:
       - name: Get current date
         id: date
-        run: echo "::set-output name=date::$(date +'%Y-%m-%d')"
+        run: echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_OUTPUT
 
       - name: Git Checkout
         uses: actions/checkout@v3
@@ -67,26 +67,22 @@ jobs:
           fi
           cd ..
 
-      - name: Merge changes to main
-        if: github.event_name == 'push'
-        run: |
-          cd dotty
-          git fetch origin main:main
-          git checkout main
-          git config user.name gh-actions
-          git config user.email [email protected]
-          git merge language-reference-stable
-          cd ..
-
-      - name: Create pull request with backport to main
-        if: github.event_name == 'push'
-        uses: peter-evans/create-pull-request@v4
+  backport-to-main:
+    name: Create pull request with backport to main
+    permissions:
+      pull-requests: write  # for repo-sync/pull-request to create a PR
+    runs-on: ubuntu-latest
+    if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'
+    steps:
+      - uses: actions/checkout@v3
+      - uses: repo-sync/pull-request@v2
         with:
-          path: dotty
-          branch: language-reference-backport
-          labels: area:documentation
-          title: Backport changes from stable documentation branch
-          body: This pull request is created automatically after push to stable documentation branch and backports the changes
-          reviewers: pikinier20,julienrf
-          assignees: pikinier20
+          destination_branch: main
+          pr_label: area:documentation
+          pr_title: Sync with the stable documentation branch
+          pr_body: |
+            This pull request is syncing the main with changes from language-reference-stable.
+
+            It was created automatically after ${{ github.event.head_commit.id }} by @${{ github.event.head_commit.author.username }}
+          pr_assignee: ${{ github.event.head_commit.author.username }}
 

.gitignore

@@ -35,6 +35,9 @@ metals.sbt
 .idea_modules
 /.worksheet/
 
+# scala-cli
+.scala-build
+
 # Partest
 dotty.jar
 dotty-lib.jar

MAINTENANCE.md

@@ -1,9 +1,12 @@
 # Issue Supervisor Role
-This document formally defines the _Issue Supervisor_ role. This is a repository maintenance role that is assigned to core contributors on rotating basis.
+
+This document formally defines the _Issue Supervisor_ role. This is a repository maintenance role that is assigned to core contributors on a rotating basis.
 
 ## Responsibilities
-Issue supervisor is responsible for:
-- Health of the CI, nightly releases and benchmark infrastructure.
+
+The issue supervisor is responsible for:
+
+- The health of the CI, nightly releases and benchmark infrastructure.
 - PRs of external contributors: assigning someone to review, or handling themselves.
 - Triaging issues (especially new):
   - Each issue needs to be assigned an `itype` and 1 or more `area` labels.
@@ -12,42 +15,50 @@ Issue supervisor is responsible for:
   - Modifying issue labels to best capture information about the issues
     - Attempting to reproduce the issue (or label “stat:cannot reproduce”)
     - Further minimizing the issue or asking the reporter of the issue to minimize it correctly (or label “stat:needs minimization”)
+  - Identifying which issues are of considerable importance and bringing them to the attention of the team during the Dotty meeting, where they can be filtered and added to the [Future Versions](https://github.com/lampepfl/dotty/milestone/46) milestone.
 
 Other core teammates are responsible for providing information to the issue supervisor in a timely manner when it is requested if they have that information.
 
 ## Assignment
-Issue supervisor is appointed for 7 days and is responsible for what is specified in the “Responsibilities” section during those 7 days. Their assumption of the role starts from the Dotty Meeting on Monday and ends on the next Dotty Meeting on Monday.
+
+The issue supervisor is appointed for 7 days and is responsible for what is specified in the “Responsibilities” section during those 7 days. Their assumption of the role starts from the Dotty Meeting on Monday and ends on the next Dotty Meeting on Monday.
 
 During the Dotty Meeting, an issue supervisor is assigned for the current week and for the week after that.
 
-Issue supervisor schedule is maintained in the [Issue Supervisor Statistics spreadsheet](https://docs.google.com/spreadsheets/d/19IAqNzHfJ9rsii3EsjIGwPz5BLTFJs_byGM3FprmX3E/edit?usp=sharing). So, someone who knows their availability several weeks ahead into the future can assign themselves to be an issue supervisor well ahead of time.
+The issue supervisor schedule is maintained in the [Issue Supervisor Statistics spreadsheet](https://docs.google.com/spreadsheets/d/19IAqNzHfJ9rsii3EsjIGwPz5BLTFJs_byGM3FprmX3E/edit?usp=sharing). So, someone who knows their availability several weeks ahead into the future can assign themselves to be an issue supervisor well ahead of time.
 
 ## Prerequisites
+
 An issue supervisor needs to have all the accesses and privileges required to get their job done. This might include:
+
 - Admin rights in lampepfl/dotty repository
 - Admin rights in lampepfl/dotty-feature-requests repository
-- Permissions to create new repositories in lampepfl organization (needed to fork repositories for the community build)
+- Permission to create new repositories in lampepfl organization (needed to fork repositories for the community build)
 - Access to the LAMP slack to be able to ask for help with the infrastructure, triaging and such
 
 ## Procedures
-To ensure proper health of the infrastructure, the supervisor regularly monitors its proper operation. If a malfunction is detected, the supervisor's job is to ensure that someone is working on it (or solve it on their own).
+
+To ensure the proper health of the infrastructure, the supervisor regularly monitors its proper operation. If a malfunction is detected, the supervisor's job is to ensure that someone is working on it (or solve it on their own).
 
 If it is unclear what area an issue belongs to, the supervisor asks for advice from other team members on Slack or GitHub. If, after asking for advice, it turns out that nobody in the team knows how to classify it, the issue must be classified with a “stat:needs triage” label.
 
 If it is unclear who should review an external PR, the supervisor asks for advice from the rest of the core team. If after asking for advice, it is still unclear who should do it, the reviewer for such a PR will be decided at the next Dotty meeting.
 
-In general, if anything else is unclear for proper fulfillment of responsibilities, the supervisor must proactively seek advice from other team members on Slack or other channels.
+In general, if anything else is unclear for the proper fulfillment of responsibilities, the supervisor must proactively seek advice from other team members on Slack or other channels.
 
 ## Reporting
+
 At the end of their supervision period, the supervisor reports to the team during the Dotty meeting on the following points:
 
 - Whether there were any incidents with the CI, nightlies and benchmarks, how they were resolved and what steps were taken to prevent them from happening in the future.
 - How many new external contributors’ PRs were there and what they were about (in brief).
 - How many new issues were opened during their supervision period? Were there any areas that got a lot of issues? How many regressions from a prior Scala 3 release were there? Which were designated for an MSc project or an Issue Spree?
 - If new labels were created or old ones were removed, or there is any other feedback on how to improve the issue supervision, mention that.
 - Unassigned PRs and issues that the team failed to classify: bring them one by one so that the team can make a decision on them.
+- Issues of importance – candidates for the Future Versions milestone.
+
+## Maintenance List
 
-# Maintenance List
 The following is the list of all the principal areas of the compiler and the core team members who are responsible for their maintenance:
 
 - Parser: @odersky
@@ -73,5 +84,5 @@ The following is the list of all the principal areas of the compiler and the cor
 - Vulpix: @dwijnand, @prolativ
 - JVM backend: @Kordyjan, (@sjrd)
 - Derivation & Mirrors: @bishabosha, (@dwijnand)
-- Linting (especially unused warnings) / Reporting UX  : VirtusLab TBD?
+- Linting (especially unused warnings) / Reporting UX: VirtusLab TBD?
 - Java-compat: @Kordyjan

changelogs/3.2.1-RC1.md

@@ -0,0 +1,189 @@
+# Highlights of the release
+
+- Add experimental capture checking [#15877](https://github.com/lampepfl/dotty/pull/15877)
+- Scaladoc: New UI design [#15697](https://github.com/lampepfl/dotty/pull/15697)
+
+# Other changes and fixes
+
+## Backend
+
+- Set ACC_FINAL access flag to final variable accessors [#15707](https://github.com/lampepfl/dotty/pull/15707)
+
+## Coverage
+
+- Avoid instrumentation of inline and erased definitions [#15504](https://github.com/lampepfl/dotty/pull/15504)
+
+## Erasure
+
+- Fix #15199: Exclude JavaDefined Modules from bridge generation. [#15499](https://github.com/lampepfl/dotty/pull/15499)
+
+## Extension Methods
+
+- Merge nested polytypes in more cases in resolveOverloaded [#15636](https://github.com/lampepfl/dotty/pull/15636)
+
+## GADTs
+
+- Fix GADT casting when typing if expressions [#15646](https://github.com/lampepfl/dotty/pull/15646)
+- Use GADT constraints in maximiseType [#15544](https://github.com/lampepfl/dotty/pull/15544)
+- Add the expected type to Poly's desugaring [#15570](https://github.com/lampepfl/dotty/pull/15570)
+- Allow refineUsingParent to infer GADT bounds [#15706](https://github.com/lampepfl/dotty/pull/15706)
+- Avoid leaking internal types in GadtConstraint.approximation [#15558](https://github.com/lampepfl/dotty/pull/15558)
+- Improve GADT usage tracing for MatchType reduction [#15872](https://github.com/lampepfl/dotty/pull/15872)
+- Add `gadtAddBound` to ExplainingTypeComparer tracing [#15819](https://github.com/lampepfl/dotty/pull/15819)
+
+## IDE Support
+
+- Recover from TypeErrors in isErroneous [#15442](https://github.com/lampepfl/dotty/pull/15442)
+- Add a guard against empty ident [#15542](https://github.com/lampepfl/dotty/pull/15542)
+
+## Initialization
+
+- Fix #15465: Use resolveThis for outerSelect resolution [#15606](https://github.com/lampepfl/dotty/pull/15606)
+- Fix #15459: Display uninitialized fields in promotion error [#15488](https://github.com/lampepfl/dotty/pull/15488)
+- Fix #15363: Improve error messages for leaking of this [#15364](https://github.com/lampepfl/dotty/pull/15364)
+- Make sure inner classes are checked first [#15527](https://github.com/lampepfl/dotty/pull/15527)
+- Handle super accessors in initialization checker [#15703](https://github.com/lampepfl/dotty/pull/15703)
+
+## Inline
+
+- Check is inline unapply has leading implicits [#15583](https://github.com/lampepfl/dotty/pull/15583)
+- Fix #15374: Make sure prefix of outer select has the correct class symbol [#15592](https://github.com/lampepfl/dotty/pull/15592)
+
+## Java Interoperability
+
+- Don't check import selectors for Java code [#15617](https://github.com/lampepfl/dotty/pull/15617)
+
+## JS Interoperability
+
+- Fix #15701: Implement js.dynamicImport for dynamic module loading. [#15720](https://github.com/lampepfl/dotty/pull/15720)
+- Implement support for js.`new`.target. [#15734](https://github.com/lampepfl/dotty/pull/15734)
+- Fix #14488: Scala.js: Add compiler support for scala.Enumeration. [#15770](https://github.com/lampepfl/dotty/pull/15770)
+
+## Match Types
+
+- Avoid null types when reducing match types [#15748](https://github.com/lampepfl/dotty/pull/15748)
+- Avoid references to unbound parameters in applied type patterns [#15710](https://github.com/lampepfl/dotty/pull/15710)
+
+## Nullability
+
+- Fix checking ctx to carry correct modes [#15350](https://github.com/lampepfl/dotty/pull/15350)
+
+## Pattern Matching
+
+- Teach provablyDisjoint to handle FromJavaObject [#15769](https://github.com/lampepfl/dotty/pull/15769)
+- Don't trust case class extractors with explicit type arguments [#15669](https://github.com/lampepfl/dotty/pull/15669)
+- Space: Fix how sealed abstract classes decompose [#15553](https://github.com/lampepfl/dotty/pull/15553)
+- Local classes are uncheckable (type tests) [#15134](https://github.com/lampepfl/dotty/pull/15134)
+- Fix ValDef span assignment in PatternMatcher [#15783](https://github.com/lampepfl/dotty/pull/15783)
+- Reject all explicitly written type references with bad bounds [#15577](https://github.com/lampepfl/dotty/pull/15577)
+
+## Pickling
+
+- Make simplify replace type parameters inside method types [#15430](https://github.com/lampepfl/dotty/pull/15430)
+
+## Quotes
+
+- Ignore types in macro runtime dependencies [#15529](https://github.com/lampepfl/dotty/pull/15529)
+
+## REPL
+
+- ReplDriver.run and :load take complete input [#15811](https://github.com/lampepfl/dotty/pull/15811)
+- REPL goes through a phase [#15663](https://github.com/lampepfl/dotty/pull/15663)
+- Avoid assertion failure for illegal trait inheritance [#15631](https://github.com/lampepfl/dotty/pull/15631)
+
+## Reporting
+
+- Underline assignment correctly in error message [#15584](https://github.com/lampepfl/dotty/pull/15584)
+- Better error message for "implicit search must be more specific"  [#15747](https://github.com/lampepfl/dotty/pull/15747)
+- Provide better info on compiler crashes [#15890](https://github.com/lampepfl/dotty/pull/15890)
+
+## SemanticDB
+
+- Handle colons in file names when producing SemanticDB [#15863](https://github.com/lampepfl/dotty/pull/15863)
+
+## Standard Library
+
+- Fix `throwReturn` of `NonLocalReturns` to allow wider usage [#15495](https://github.com/lampepfl/dotty/pull/15495)
+
+## Tooling
+
+- Fix scala runner exit codes [#15604](https://github.com/lampepfl/dotty/pull/15604)
+- Command line parser respects outer escaped quote [#15497](https://github.com/lampepfl/dotty/pull/15497)
+- Added quotes to Scala home paths in scala and scalac scripts [#15824](https://github.com/lampepfl/dotty/pull/15824)
+- Retain partial type params typying information on error [#15825](https://github.com/lampepfl/dotty/pull/15825)
+
+## Transform
+
+- Implementation restriction: No partial functions with CFT results [#15744](https://github.com/lampepfl/dotty/pull/15744)
+- Fix treatment of parameter selections via this in constructors. [#15737](https://github.com/lampepfl/dotty/pull/15737)
+- Fix expansion and unexpansion of mixin qualified names [#15712](https://github.com/lampepfl/dotty/pull/15712)
+- Fix #15514 in Parser [#15524](https://github.com/lampepfl/dotty/pull/15524)
+- Check type arguments for bad bounds [#15571](https://github.com/lampepfl/dotty/pull/15571)
+
+## Typer
+
+- Fix swapKey [#15894](https://github.com/lampepfl/dotty/pull/15894)
+- Insert GADT casts for needy match types [#15851](https://github.com/lampepfl/dotty/pull/15851)
+- Add missing dealias in isContextFunctionRef [#15742](https://github.com/lampepfl/dotty/pull/15742)
+- Look for synthetic applies also under type applications [#15572](https://github.com/lampepfl/dotty/pull/15572)
+- Optimize isSameType for invariant applied types with the same structure [#15556](https://github.com/lampepfl/dotty/pull/15556)
+- Fix cycle detection for type aliases with wildcard arguments [#15508](https://github.com/lampepfl/dotty/pull/15508)
+- Handle recursions in isFullyDefined [#15443](https://github.com/lampepfl/dotty/pull/15443)
+- Do level checking on instantiation [#15746](https://github.com/lampepfl/dotty/pull/15746)
+- Use fullyDefinedType for mirror synthesis [#15814](https://github.com/lampepfl/dotty/pull/15814)
+- Instantiate more type variables to hard unions [#15632](https://github.com/lampepfl/dotty/pull/15632)
+- Simplify level fixing scheme [#15936](https://github.com/lampepfl/dotty/pull/15936)
+- Don't normalize in `AppliedType#superType` [#15453](https://github.com/lampepfl/dotty/pull/15453)
+- Try promotion while widening arguments [#15467](https://github.com/lampepfl/dotty/pull/15467)
+- Check import selectors at Typer [#15477](https://github.com/lampepfl/dotty/pull/15477)
+- Turn some calls to `underlying` into `superType`. [#15455](https://github.com/lampepfl/dotty/pull/15455)
+- Find more looping implicits [#15481](https://github.com/lampepfl/dotty/pull/15481)
+- Fix `findFunctionType` for `OrTypes` [#15478](https://github.com/lampepfl/dotty/pull/15478)
+- Fix looping implicits check [#15655](https://github.com/lampepfl/dotty/pull/15655)
+- Try to avoid static symbols if leaving them would make a leak [#15548](https://github.com/lampepfl/dotty/pull/15548)
+- Do not fold `IsConst` applied to dependent parameters [#15759](https://github.com/lampepfl/dotty/pull/15759)
+
+# Contributors
+
+Thank you to all the contributors who made this release possible 🎉
+
+According to `git shortlog -sn --no-merges 3.1.3..3.2.0` these are:
+
+```
+   204 Martin Odersky
+    94 Filip Łukasik
+    69 Fengyun Liu
+    57 Filip Zybała
+    31 Dale Wijnand
+    14 Sébastien Doeraene
+    10 Guillaume Raffin
+     9 rochala
+     8 Chris Kipp
+     8 Paweł Marks
+     8 Som Snytt
+     7 Jędrzej Rochala
+     7 Nicolas Stucki
+     7 Yichen Xu
+     6 Jamie Thompson
+     6 Tom Grigg
+     5 noti0na1
+     2 Arman Bilge
+     2 Kacper Korban
+     2 Matt Bovel
+     2 Ondrej Lhotak
+     2 Quentin Bernet
+     2 Tomasz Godzik
+     1 Adrien Piquerez
+     1 Florian3k
+     1 Gagandeep Kalra
+     1 Jentsch
+     1 Kieren Davies
+     1 Michał Pałka
+     1 Naveen
+     1 Oron Port
+     1 Rubin Simons
+     1 Seth Tisue
+     1 Wojciech Mazur
+     1 esteban marin
+     1 naveen
+```