Skip to content

Commit c1c724b

Browse files
committed
Remove outadted TODOs
Before, there was a super type of all abstract types in scala.Tasty. This made it possible to match some ident with the wrong type of extractor.
1 parent d3b3192 commit c1c724b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

compiler/src/dotty/tools/dotc/tastyreflect/TastyImpl.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class TastyImpl(val rootContext: Contexts.Context) extends scala.tasty.Tasty wit
6262

6363
object Id extends IdExtractor {
6464
def unapply(x: Id): Option[String] = x match {
65-
case x: untpd.Ident => Some(x.name.toString) // TODO how to make sure it is not a Ident or TypeIdent? Check x.tpe?
65+
case x: untpd.Ident => Some(x.name.toString)
6666
case _ => None
6767
}
6868
}
@@ -117,7 +117,7 @@ class TastyImpl(val rootContext: Contexts.Context) extends scala.tasty.Tasty wit
117117

118118
object SimpleSelector extends SimpleSelectorExtractor {
119119
def unapply(x: ImportSelector)(implicit ctx: Context): Option[Id] = x match {
120-
case x: untpd.Ident => Some(x) // TODO make sure it will not match other idents
120+
case x: untpd.Ident => Some(x)
121121
case _ => None
122122
}
123123
}

0 commit comments

Comments
 (0)