Skip to content

Commit c04bf22

Browse files
committed
Dropped ??? in arrayclass
The patch caused the built dotty not to run anymore. Since the prupose of the ??? was to find out where it was called I inserted the stacktrace that caused dotc to fail. I wonder how this passed the tests? Dotc became completely useless for me when I ran it from the command line.
1 parent d4e4e24 commit c04bf22

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/scala/runtime/ScalaRunTime.scala

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,13 @@ object ScalaRunTime {
5050
/** Return the class object representing an array with element class `clazz`.
5151
*/
5252
def arrayClass(clazz: jClass[_]): jClass[_] = {
53-
??? // Dmitry: I want to see where this method is used to know how to fix it
53+
// Dmitry: I want to see where this method is used to know how to fix it
54+
// [Martin] Here's a stacktrace
55+
// Exception in thread "main" scala.NotImplementedError: an implementation is missing
56+
// at scala.Predef$.$qmark$qmark$qmark(Predef.scala:225)
57+
// at scala.runtime.ScalaRunTime$.arrayClass(ScalaRunTime.scala:53)
58+
// at scala.Array$.fill(Array.scala:281)
59+
// at dotty.tools.dotc.core.Flags$.<init>(Flags.scala:139)
5460
// newInstance throws an exception if the erasure is Void.TYPE. see SI-5680
5561
if (clazz == java.lang.Void.TYPE) classOf[Array[Unit]]
5662
else java.lang.reflect.Array.newInstance(clazz, 0).getClass

0 commit comments

Comments
 (0)