Merge pull request #1596 from dotty-staging/fix-#1531

Fix #1531: Ignore private members when looking for abstract ones

Author: smarter

src/dotty/tools/dotc/core/Types.scala

@@ -620,13 +620,13 @@ object Types {
     /** The set of abstract term members of this type. */
     final def abstractTermMembers(implicit ctx: Context): Seq[SingleDenotation] = track("abstractTermMembers") {
       memberDenots(abstractTermNameFilter,
-          (name, buf) => buf ++= member(name).altsWith(_ is Deferred))
+          (name, buf) => buf ++= nonPrivateMember(name).altsWith(_ is Deferred))
     }
 
     /** The set of abstract type members of this type. */
     final def abstractTypeMembers(implicit ctx: Context): Seq[SingleDenotation] = track("abstractTypeMembers") {
       memberDenots(abstractTypeNameFilter,
-          (name, buf) => buf += member(name).asSingleDenotation)
+          (name, buf) => buf += nonPrivateMember(name).asSingleDenotation)
     }
 
     /** The set of abstract type members of this type. */
@@ -3763,7 +3763,7 @@ object Types {
   object abstractTypeNameFilter extends NameFilter {
     def apply(pre: Type, name: Name)(implicit ctx: Context): Boolean =
       name.isTypeName && {
-        val mbr = pre.member(name)
+        val mbr = pre.nonPrivateMember(name)
         (mbr.symbol is Deferred) && mbr.info.isInstanceOf[RealTypeBounds]
       }
   }
@@ -3780,7 +3780,7 @@ object Types {
   /** A filter for names of deferred term definitions of a given type */
   object abstractTermNameFilter extends NameFilter {
     def apply(pre: Type, name: Name)(implicit ctx: Context): Boolean =
-      name.isTermName && (pre member name).hasAltWith(_.symbol is Deferred)
+      name.isTermName && pre.nonPrivateMember(name).hasAltWith(_.symbol is Deferred)
   }
 
   object typeNameFilter extends NameFilter {

src/dotty/tools/dotc/typer/RefChecks.scala

@@ -487,7 +487,7 @@ object RefChecks {
             // abstract method, and a cursory examination of the difference reveals
             // something obvious to us, let's make it more obvious to them.
             val abstractParams = underlying.info.firstParamTypes
-            val matchingName = clazz.info.member(underlying.name).alternatives
+            val matchingName = clazz.info.nonPrivateMember(underlying.name).alternatives
             val matchingArity = matchingName filter { m =>
               !m.symbol.is(Deferred) &&
                 m.info.firstParamTypes.length == abstractParams.length

tests/neg/i1531.scala

@@ -0,0 +1,6 @@
+trait T {
+  def f: Int
+}
+
+class A(f: Int) extends T // error: class A needs to be abstract
+