Relax Ycheck's checkNotRepeated

OlivierBlanvillain · OlivierBlanvillain · commit b9db9f62318f · 2018-01-18T11:54:01.000+01:00
See i3248.scala for an example of a non case class pattern leaking
scala.annotation.internal.Repeated.
diff --git a/compiler/src/dotty/tools/dotc/transform/TreeChecker.scala b/compiler/src/dotty/tools/dotc/transform/TreeChecker.scala
@@ -288,7 +288,7 @@ class TreeChecker extends Phase with SymTransformer {
     }
 
     def checkNotRepeated(tree: Tree)(implicit ctx: Context): tree.type = {
-      def allowedRepeated = (tree.symbol.flags is Case) && tree.tpe.widen.isRepeatedParam
+      def allowedRepeated = tree.tpe.widen.isRepeatedParam
 
       assert(!tree.tpe.widen.isRepeatedParam || allowedRepeated, i"repeated parameter type not allowed here: $tree")
       tree

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ class TreeChecker extends Phase with SymTransformer {`
`288`	`288`	`}`
`289`	`289`
`290`	`290`	`def checkNotRepeated(tree: Tree)(implicit ctx: Context): tree.type = {`
`291`		`- def allowedRepeated = (tree.symbol.flags is Case) && tree.tpe.widen.isRepeatedParam`
	`291`	`+ def allowedRepeated = tree.tpe.widen.isRepeatedParam`
`292`	`292`
`293`	`293`	`assert(!tree.tpe.widen.isRepeatedParam \|\| allowedRepeated, i"repeated parameter type not allowed here: $tree")`
`294`	`294`	`tree`