Fix #17577: scaladoc hangs with deep inheritance

This commit has a pair of fixes that bring the scaladoc build time for the repository mentioned in #17577 to a minute instead of hanging.

- Reimplement HierarchyGraph's `+` method in terms of `++` Previously, `++` was implemented in terms of `+`, but `+` called `distinct` resulting in poor performance. Now `distinct` is only called once for a `++` call.
- Use Set instead of Seq for `InheritanceInformationTransformer.getEdges`. Previously, `subtypes` could contain duplicates, causing excess calls to `getEdges`

Author: reardonj

scaladoc/src/dotty/tools/scaladoc/api.scala

@@ -145,10 +145,10 @@ case class LinkToType(signature: Signature, dri: DRI, kind: Kind)
 case class HierarchyGraph(edges: Seq[(LinkToType, LinkToType)], sealedNodes: Set[LinkToType] = Set.empty):
   def vertecies: Seq[LinkToType] = edges.flatten((a, b) => Seq(a, b)).distinct
   def verteciesWithId: Map[LinkToType, Int] = vertecies.zipWithIndex.toMap
-  def +(edge: (LinkToType, LinkToType)): HierarchyGraph = HierarchyGraph((edges :+ edge).distinct)
-  def ++(edges: Seq[(LinkToType, LinkToType)]): HierarchyGraph = edges.foldLeft(this) {
-    case (acc, edge) => acc + edge
-  }
+  def +(edge: (LinkToType, LinkToType)): HierarchyGraph = this ++ Seq(edge)
+  def ++(edges: Seq[(LinkToType, LinkToType)]): HierarchyGraph = 
+    this.copy(edges = this.edges.view.concat(edges).distinct.toSeq)
+    
 object HierarchyGraph:
   def empty = HierarchyGraph(Seq.empty)
   def withEdges(edges: Seq[(LinkToType, LinkToType)]) = HierarchyGraph.empty ++ edges

scaladoc/src/dotty/tools/scaladoc/transformers/InheritanceInformationTransformer.scala

@@ -3,16 +3,16 @@ package transformers
 
 class InheritanceInformationTransformer(using DocContext) extends (Module => Module):
   override def apply(original: Module): Module =
-    val subtypes = getSupertypes(original.rootPackage).groupMap(_(0))(_(1))
+    val subtypes = getSupertypes(original.rootPackage).groupMap(_(0))(_(1)).view.mapValues(_.toSet).toMap
     original.updateMembers { m =>
       val edges = getEdges(m.asLink.copy(kind = bareClasslikeKind(m.kind)), subtypes)
-      val st: Seq[LinkToType] = edges.map(_._1).distinct
-      m.withKnownChildren(st).withNewGraphEdges(edges)
+      val st: Seq[LinkToType] = edges.map(_._1).toSeq
+      m.withKnownChildren(st).withNewGraphEdges(edges.toSeq)
     }
 
-  private def getEdges(ltt: LinkToType, subtypes: Map[DRI, Seq[LinkToType]]): Seq[(LinkToType, LinkToType)] =
-    val st: Seq[LinkToType] = subtypes.getOrElse(ltt.dri, Nil)
-    st.flatMap(s => Seq(s -> ltt) ++ getEdges(s, subtypes))
+  private def getEdges(ltt: LinkToType, subtypes: Map[DRI, Set[LinkToType]]): Set[(LinkToType, LinkToType)] =
+    val st: Set[LinkToType] = subtypes.getOrElse(ltt.dri, Set.empty)
+    st.flatMap(s => Set(s -> ltt) ++ getEdges(s, subtypes))
 
   private def bareClasslikeKind(kind: Kind): Kind = kind match
     case _: Kind.Trait => Kind.Trait(Nil, Nil)