Merge pull request #12031 from dotty-staging/fix-type-member-select

Fix selceting type member in unsafe nulls

Author: odersky

compiler/src/dotty/tools/dotc/core/Types.scala

@@ -237,7 +237,7 @@ object Types {
     }
 
     def isBottomType(using Context): Boolean =
-      if ctx.explicitNulls && !ctx.phase.erasedTypes then hasClassSymbol(defn.NothingClass)
+      if ctx.mode.is(Mode.SafeNulls) && !ctx.phase.erasedTypes then hasClassSymbol(defn.NothingClass)
       else isBottomTypeAfterErasure
 
     def isBottomTypeAfterErasure(using Context): Boolean =

tests/explicit-nulls/unsafe-common/unsafe-select-type-member.scala

@@ -0,0 +1,7 @@
+import java.util.ArrayList
+
+def f[T]: ArrayList[T] = {
+  val cz = Class.forName("java.util.ArrayList")
+  val o = cz.newInstance() // error: T of Class[?] | Null
+  o.asInstanceOf[ArrayList[T]]
+}