Remove dependency between dotty-compiler and dotty-library

Author: OlivierBlanvillain

compiler/src/dotty/tools/dotc/core/Denotations.scala

@@ -71,8 +71,6 @@ import Decorators.SymbolIteratorDecorator
  */
 object Denotations {
 
-  implicit def eqDenotation: Eq[Denotation, Denotation] = Eq
-
   /** A denotation is the result of resolving
    *  a name (either simple identifier or select) during a given period.
    *

compiler/src/dotty/tools/dotc/core/Names.scala

@@ -26,8 +26,6 @@ object Names {
     def toTermName: TermName
   }
 
-  implicit def eqName: Eq[Name, Name] = Eq
-
   /** A name is essentially a string, with three differences
    *  1. Names belong in one of two name spaces: they are type names or term names.
    *     Term names have a sub-category of "local" field names.

compiler/src/dotty/tools/dotc/core/Symbols.scala

@@ -378,8 +378,6 @@ trait Symbols { this: Context =>
 
 object Symbols {
 
-  implicit def eqSymbol: Eq[Symbol, Symbol] = Eq
-
   /** A Symbol represents a Scala definition/declaration or a package.
    *  @param coord  The coordinates of the symbol (a position or an index)
    *  @param id     A unique identifier of the symbol (unique per ContextBase)

compiler/src/dotty/tools/dotc/core/Types.scala

@@ -40,8 +40,6 @@ object Types {
 
   @sharable private var nextId = 0
 
-  implicit def eqType: Eq[Type, Type] = Eq
-
   /** Main class representing types.
    *
    *  The principal subclasses and sub-objects are as follows:

compiler/src/dotty/tools/dotc/transform/LazyVals.scala

@@ -347,7 +347,8 @@ class LazyVals extends MiniPhaseTransform with IdentityDenotTransformer {
         // compute or create appropriate offsetSymol, bitmap and bits used by current ValDef
         appendOffsetDefs.get(claz) match {
           case Some(info) =>
-            val flagsPerLong = (64 / dotty.runtime.LazyVals.BITS_PER_LAZY_VAL).toInt
+            val BITS_PER_LAZY_VAL = 2L // To be kept in sync with dotty.runtime.LazyVals.BITS_PER_LAZY_VAL
+            val flagsPerLong = (64 / BITS_PER_LAZY_VAL).toInt
             info.ord += 1
             ord = info.ord % flagsPerLong
             val id = info.ord / flagsPerLong
@@ -398,14 +399,15 @@ class LazyVals extends MiniPhaseTransform with IdentityDenotTransformer {
 object LazyVals {
   object lazyNme {
     object RLazyVals {
-      import dotty.runtime.LazyVals._
-      val get               = Names.get.toTermName
-      val setFlag           = Names.setFlag.toTermName
-      val wait4Notification = Names.wait4Notification.toTermName
-      val state             = Names.state.toTermName
-      val cas               = Names.cas.toTermName
-      val getOffset         = Names.getOffset.toTermName
+      // To be kept in sync with dotty.runtime.LazyVals.Names._
+      val cas               = "CAS".toTermName
+      val get               = "get".toTermName
+      val getOffset         = "getOffset".toTermName
+      val setFlag           = "setFlag".toTermName
+      val state             = "STATE".toTermName
+      val wait4Notification = "wait4Notification".toTermName
     }
+
     val flag        = "flag".toTermName
     val result      = "result".toTermName
     val value       = "value".toTermName

library/src/dotty/runtime/LazyVals.scala

@@ -8,7 +8,7 @@ import scala.annotation.tailrec
 object LazyVals {
   private val unsafe = scala.concurrent.util.Unsafe.instance
 
-  final val BITS_PER_LAZY_VAL = 2L
+  final val BITS_PER_LAZY_VAL = 2L // To be kept in sync with dotty/tools/dotc/transform/LazyVals.scala
   final val LAZY_VAL_MASK = 3L
   final val debug = false
 
@@ -91,7 +91,7 @@ object LazyVals {
     r
   }
 
-  object Names {
+  object Names { // To be kept in sync with dotty/tools/dotc/transform/LazyVals.scala
     final val state = "STATE"
     final val cas = "CAS"
     final val setFlag = "setFlag"