Skip to content

Commit a74feb6

Browse files
author
Aurélien Richez
committed
code review : removes unnecessary override/types and improves test
1 parent 78ade4c commit a74feb6

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1925,9 +1925,9 @@ object messages {
19251925

19261926
case class PackageNameAlreadyDefined(pkg: Symbol)(implicit ctx: Context) extends Message(PackageNameAlreadyDefinedID) {
19271927

1928-
override def msg: String = hl"${pkg} is already defined, cannot be a package"
1929-
override def kind: String = "Syntax"
1930-
override def explanation: String =
1931-
"An object cannot have the same name as an existing package. Rename ${pkg} or the package with the same name."
1928+
val msg = hl"${pkg} is already defined, cannot be a ${"package"}"
1929+
val kind = "Syntax"
1930+
val explanation =
1931+
hl"An ${"object"} cannot have the same name as an existing ${"package"}. Rename either one of them."
19321932
}
19331933
}

compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1200,7 +1200,7 @@ class ErrorMessagesTests extends ErrorMessagesTest {
12001200
}.expect { (ictx, messages) =>
12011201
implicit val ctx: Context = ictx
12021202

1203-
assertMessageCount(1, messages)
1204-
assert(messages.head.isInstanceOf[PackageNameAlreadyDefined])
1203+
val PackageNameAlreadyDefined(pkg) = messages.head
1204+
assertEquals(pkg.show, "object bar")
12051205
}
12061206
}

0 commit comments

Comments
 (0)