Skip to content

Commit 9a9e984

Browse files
Merge pull request #4175 from dotty-staging/fix/flakey-tests
Turn off the flakey VulpixMetaTests
2 parents f021702 + 59aee4d commit 9a9e984

File tree

1 file changed

+21
-20
lines changed

1 file changed

+21
-20
lines changed

project/scripts/cmdTests

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -78,23 +78,24 @@ echo "testing ./bin/dotd"
7878
clear_out "$OUT"
7979
./bin/dotd -project Hello -siteroot "$OUT" "$SOURCE"
8080

81-
echo "running Vulpix meta test"
82-
tmp=$(mktemp)
83-
if "$SBT" "dotty-compiler/testOnly dotty.tools.vulpix.VulpixMetaTests" > "$tmp" 2>&1; then
84-
cat "$tmp"
85-
echo "failed: sbt exited without error on VulpixMetaTests, these tests are expected to fail"
86-
exit -1
87-
fi
88-
tmp1=$(mktemp)
89-
cat "$tmp" | sed '/Test run started/,$!d' > "$tmp1"
90-
set +x # Or the code below produces too much noise
91-
while read expected <&4 && read actual <&3; do
92-
if [[ "$expected" != *"SKIP" ]]; then
93-
if [ "$actual" != "$expected" ]; then
94-
echo "failed Vulpix meta: the output of sbt differs from the expected output"
95-
echo "expected : $expected"
96-
echo "actual : $actual"
97-
exit -1
98-
fi
99-
fi
100-
done 3<"$tmp1" 4<"./tests/vulpix-tests/meta/sbt-output.check"
81+
## Disabled because of flakeyness, should be changed to not depend on sbt
82+
# echo "running Vulpix meta test"
83+
# tmp=$(mktemp)
84+
# if "$SBT" "dotty-compiler/testOnly dotty.tools.vulpix.VulpixMetaTests" > "$tmp" 2>&1; then
85+
# cat "$tmp"
86+
# echo "failed: sbt exited without error on VulpixMetaTests, these tests are expected to fail"
87+
# exit -1
88+
# fi
89+
# tmp1=$(mktemp)
90+
# cat "$tmp" | sed '/Test run started/,$!d' > "$tmp1"
91+
# set +x # Or the code below produces too much noise
92+
# while read expected <&4 && read actual <&3; do
93+
# if [[ "$expected" != *"SKIP" ]]; then
94+
# if [ "$actual" != "$expected" ]; then
95+
# echo "failed Vulpix meta: the output of sbt differs from the expected output"
96+
# echo "expected : $expected"
97+
# echo "actual : $actual"
98+
# exit -1
99+
# fi
100+
# fi
101+
# done 3<"$tmp1" 4<"./tests/vulpix-tests/meta/sbt-output.check"

0 commit comments

Comments
 (0)