Skip to content

Commit 9a3356d

Browse files
committed
Use sbt makeScalaInstance
1 parent 45e2ad7 commit 9a3356d

File tree

4 files changed

+19
-72
lines changed

4 files changed

+19
-72
lines changed

project/Bootstrap.scala

Lines changed: 0 additions & 55 deletions
This file was deleted.

project/Build.scala

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -372,8 +372,8 @@ object Build {
372372
// Compile using the non-bootstrapped and non-published dotty
373373
managedScalaInstance := false,
374374
scalaInstance := {
375-
val externalLibraryDeps = (`scala3-library` / Compile / externalDependencyClasspath).value.map(_.data).toSet
376-
val externalCompilerDeps = (`scala3-compiler` / Compile / externalDependencyClasspath).value.map(_.data).toSet
375+
val externalLibraryDeps = (`scala3-library` / Compile / externalDependencyClasspath).value.map(_.data)
376+
val externalCompilerDeps = (`scala3-compiler` / Compile / externalDependencyClasspath).value.map(_.data)
377377

378378
// IMPORTANT: We need to use actual jars to form the ScalaInstance and not
379379
// just directories containing classfiles because sbt maintains a cache of
@@ -386,15 +386,14 @@ object Build {
386386
val scala3Compiler = (`scala3-compiler` / Compile / packageBin).value
387387

388388
val libraryJars = Array(scala3Library) ++ externalLibraryDeps
389-
val compilerJars = Array(tastyCore, scala3Interfaces, scala3Compiler) ++ (externalCompilerDeps -- externalLibraryDeps)
389+
val compilerJars = Seq(tastyCore, scala3Interfaces, scala3Compiler) ++ externalCompilerDeps
390390

391-
// should be replaced by sbt.Defaults.makeScalaInstance when released
392-
// See https://github.com/sbt/sbt/pull/6480
393-
Bootstrap.makeScalaInstance(
394-
state.value,
391+
Defaults.makeScalaInstance(
395392
scalaVersion.value,
396393
libraryJars = libraryJars,
397-
compilerJars = compilerJars,
394+
allCompilerJars = compilerJars,
395+
allDocJars = Seq.empty,
396+
state.value,
398397
scalaInstanceTopLoader.value
399398
)
400399
},
@@ -404,15 +403,18 @@ object Build {
404403
// in the `scalaInstance` of the `doc` task which allows us to run
405404
// `scala3-library-bootstrapped/doc` for example.
406405
doc / scalaInstance := {
407-
val externalCompilerDeps = (`scala3-compiler` / Compile / externalDependencyClasspath).value.map(_.data).toSet
408-
val externalScaladocDeps = (LocalProject("scaladoc") / Compile / externalDependencyClasspath).value.map(_.data).toSet
406+
val externalDeps = (LocalProject("scaladoc") / Compile / externalDependencyClasspath).value.map(_.data)
409407
val scalaDoc = (LocalProject("scaladoc") / Compile / packageBin).value
410-
val docJars = Array(scalaDoc) ++ (externalScaladocDeps -- externalCompilerDeps)
411-
412-
Bootstrap.makeDocScalaInstance(
408+
val docJars = Array(scalaDoc) ++ externalDeps
409+
410+
val base = scalaInstance.value
411+
Defaults.makeScalaInstance(
412+
version = base.version,
413+
libraryJars = base.libraryJars,
414+
allCompilerJars = base.compilerJars,
415+
allDocJars = docJars,
413416
state.value,
414-
scalaInstance.value,
415-
docJars
417+
scalaInstanceTopLoader.value
416418
)
417419
},
418420
Compile / doc / scalacOptions ++= scalacOptionsDocSettings

project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version=1.5.2
1+
sbt.version=1.5.3

project/project/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// Some dependencies are shared between the regular build and the meta-build
2-
sources in Compile += baseDirectory.value / "../Dependencies.scala"
2+
Compile / sources += baseDirectory.value / "../Dependencies.scala"

0 commit comments

Comments
 (0)