Skip to content

Commit 94d05a4

Browse files
committed
Exclude nullable.scala from pickling and fromTasy tests
Constant folding null comparisons cannot be reproduced after pickling since notNullRefs are not maintained top-down. We should drop constant folding null comparisons once full explicit nulls are in. for full explicit nulles, we need to wrap references in "assert not null" calls to keep a record of what was inferred.
1 parent 691996a commit 94d05a4

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

compiler/test/dotc/pos-from-tasty.blacklist

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,7 @@ t3612.scala
88
t802.scala
99

1010
# Matchtype
11-
i7087.scala
11+
i7087.scala
12+
13+
# Nullability
14+
nullable.scala

compiler/test/dotc/pos-test-pickling.blacklist

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,6 @@ i5720.scala
2828

2929
# Tuples
3030
toexproftuple.scala
31+
32+
# Nullability
33+
nullable.scala

0 commit comments

Comments
 (0)