Skip to content

Commit 945b31e

Browse files
committed
Fix #9115: Make Java-defined fields effectively final
1 parent 345c8bc commit 945b31e

File tree

4 files changed

+8
-1
lines changed

4 files changed

+8
-1
lines changed

compiler/src/dotty/tools/dotc/core/Flags.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ object Flags {
308308
val (Given @ _, _, _) = newFlags(29, "given")
309309

310310
/** Symbol is defined by a Java class */
311-
val (JavaDefined @ _, _, _) = newFlags(30, "<java>")
311+
val (JavaDefined @ _, JavaDefinedVal @ _, _) = newFlags(30, "<java>")
312312

313313
/** Symbol is implemented as a Java static */
314314
val (JavaStatic @ _, JavaStaticTerm @ _, JavaStaticType @ _) = newFlags(31, "<static>")

compiler/src/dotty/tools/dotc/core/SymDenotations.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1158,6 +1158,7 @@ object SymDenotations {
11581158
final def isEffectivelyFinal(implicit ctx: Context): Boolean =
11591159
isOneOf(EffectivelyFinalFlags)
11601160
|| is(Inline, butNot = Deferred)
1161+
|| is(JavaDefinedVal, butNot = Method)
11611162
|| !owner.isExtensibleClass
11621163

11631164
/** A class is effectively sealed if has the `final` or `sealed` modifier, or it

tests/neg/i9115/A.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
public class A {
2+
public String foo = "A";
3+
}

tests/neg/i9115/B.scala

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
class B extends A {
2+
override val foo: String = "B" // error
3+
}

0 commit comments

Comments
 (0)