Don't discard warnings in TestReporter for .check files of neg tests

Author: lrytz

compiler/test/dotty/tools/dotc/reporting/TestReporter.scala

@@ -73,15 +73,9 @@ extends Reporter with UniqueMessagePositions with HideNonSensicalMessages with M
       case _ => ""
     }
 
-    dia match {
-      case dia: Error => {
-        _errorBuf.append(dia)
-        _consoleReporter.doReport(dia)
-        printMessageAndPos(dia, extra)
-      }
-      case dia =>
-        printMessageAndPos(dia, extra)
-    }
+    if dia.level >= ERROR then _errorBuf.append(dia)
+    if dia.level >= WARNING then _consoleReporter.doReport(dia)
+    printMessageAndPos(dia, extra)
   }
 }
 

tests/neg/i12150.check

@@ -4,3 +4,9 @@
   |             expression expected but end found
 
 longer explanation available when compiling with `-explain`
+-- [E129] Potential Issue Warning: tests/neg/i12150.scala:1:11 ---------------------------------------------------------
+1 |def f: Unit = // error
+  |           ^
+  |           A pure expression does nothing in statement position; you may be omitting necessary parentheses
+
+longer explanation available when compiling with `-explain`

tests/neg/i2033.check

@@ -9,3 +9,7 @@
    |                                   Required: String
 
 longer explanation available when compiling with `-explain`
+-- Warning: tests/neg/i2033.scala:6:37 ---------------------------------------------------------------------------------
+6 |    val out = new ObjectOutputStream(println)
+  |                                     ^^^^^^^
+  |method println is eta-expanded even though java.io.OutputStream does not have the @FunctionalInterface annotation.

tests/neg/spaces-vs-tabs.check

@@ -28,3 +28,9 @@
    |	  The start of this line does not match any of the previous indentation widths.
    |	  Indentation width of current line : 1 tab, 2 spaces
    |	  This falls between previous widths: 1 tab and 1 tab, 4 spaces
+-- [E129] Potential Issue Warning: tests/neg/spaces-vs-tabs.scala:13:6 -------------------------------------------------
+13 |	      1
+   |	      ^
+   |	      A pure expression does nothing in statement position; you may be omitting necessary parentheses
+
+longer explanation available when compiling with `-explain`

tests/neg/t6810.check

@@ -22,3 +22,11 @@
 30 |  val b = '
    |          ^
    |          unclosed character literal
+-- Warning: tests/neg/t6810.scala:6:0 ----------------------------------------------------------------------------------
+6 |'                     // but not embedded EOL sequences not represented as escapes
+  |^
+  |Line is indented too far to the left, or a `}` is missing
+-- Warning: tests/neg/t6810.scala:31:0 ---------------------------------------------------------------------------------
+31 |'        // anypos-error CR seen as EOL by scanner; FSR, error only on open quote, unlike `y`
+   |^
+   |Line is indented too far to the left, or a `}` is missing