Skip to content

Commit 8d8baba

Browse files
author
Aurélien Richez
committed
code review : removes unnecessary override/types and improves test
1 parent a6f5fdd commit 8d8baba

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1919,9 +1919,9 @@ object messages {
19191919

19201920
case class PackageNameAlreadyDefined(pkg: Symbol)(implicit ctx: Context) extends Message(PackageNameAlreadyDefinedID) {
19211921

1922-
override def msg: String = hl"${pkg} is already defined, cannot be a package"
1923-
override def kind: String = "Syntax"
1924-
override def explanation: String =
1925-
"An object cannot have the same name as an existing package. Rename ${pkg} or the package with the same name."
1922+
val msg = hl"${pkg} is already defined, cannot be a ${"package"}"
1923+
val kind = "Syntax"
1924+
val explanation =
1925+
hl"An ${"object"} cannot have the same name as an existing ${"package"}. Rename either one of them."
19261926
}
19271927
}

compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1183,7 +1183,7 @@ class ErrorMessagesTests extends ErrorMessagesTest {
11831183
}.expect { (ictx, messages) =>
11841184
implicit val ctx: Context = ictx
11851185

1186-
assertMessageCount(1, messages)
1187-
assert(messages.head.isInstanceOf[PackageNameAlreadyDefined])
1186+
val PackageNameAlreadyDefined(pkg) = messages.head
1187+
assertEquals(pkg.show, "object bar")
11881188
}
11891189
}

0 commit comments

Comments
 (0)