Address PR comments.

Author: adampauls

compiler/src/dotty/tools/dotc/parsing/ParserPhase.scala

@@ -14,19 +14,17 @@ import dotty.tools.unsupported
 
 class Parser extends Phase {
 
-  override def phaseName: String = "parsing"
+  override def phaseName: String = Parser.name
 
   // We run TreeChecker only after type checking
   override def isCheckable: Boolean = false
 
-  override def isRunnable(implicit ctx: Context): Boolean = true
-
   /** The position of the first XML literal encountered while parsing,
    *  NoSourcePosition if there were no XML literals.
    */
   private[dotc] var firstXmlPos: SourcePosition = NoSourcePosition
 
-  def parse(using Context) = monitor("parsing") {
+  def parse(using Context) = monitor("parser") {
     val unit = ctx.compilationUnit
     unit.untpdTree =
       if (unit.isJava) new JavaParsers.JavaParser(unit.source).parse()
@@ -39,7 +37,7 @@ class Parser extends Phase {
         tree
       }
 
-    val printer = if (ctx.settings.Xprint.value.contains("parser")) default else typr
+    val printer = if (ctx.settings.Xprint.value.contains(Parser.name)) default else typr
     printer.println("parsed:\n" + unit.untpdTree.show)
     if (Config.checkPositions)
       unit.untpdTree.checkPos(nonOverlapping = !unit.isJava && !ctx.reporter.hasErrors)
@@ -49,7 +47,7 @@ class Parser extends Phase {
   override def runOn(units: List[CompilationUnit])(using Context): List[CompilationUnit] = {
     val unitContexts =
       for unit <- units yield
-        report.inform(s"running parser on ${unit.source}")
+        report.inform(s"parsing ${unit.source}")
         ctx.fresh.setCompilationUnit(unit).withRootImports
 
     unitContexts.foreach(parse(using _))
@@ -60,3 +58,7 @@ class Parser extends Phase {
 
   def run(using Context): Unit = unsupported("run")
 }
+
+object Parser{
+  val name: String = "parser"
+}

compiler/src/dotty/tools/dotc/typer/Checking.scala

@@ -795,7 +795,7 @@ trait Checking {
   private def checkLegalImportOrExportPath(path: Tree, kind: String)(using Context): Unit = {
     checkStable(path.tpe, path.srcPos, kind)
     if (!ctx.isAfterTyper) Checking.checkRealizable(path.tpe, path.srcPos)
-    if ctx.phase.isCheckable && !isIdempotentExpr(path) then
+    if !isIdempotentExpr(path) then
       report.error(em"import prefix is not a pure expression", path.srcPos)
   }
 

compiler/src/dotty/tools/dotc/typer/TyperPhase.scala

@@ -76,6 +76,7 @@ class TyperPhase extends Phase {
     val unitContexts =
       for unit <- units yield
         val newCtx = ctx.fresh.setPhase(this.start).setCompilationUnit(unit)
+        report.inform(s"typing ${unit.source}")
         // TODO without this test, dotty.tools.repl.ScriptedTests fails. Not sure why.
         if (this.start > Periods.FirstPhaseId)
           newCtx.withRootImports