Avoid orphan parameters in Constraint#replace

odersky · odersky · commit 85853252be8b · 2016-07-02T16:51:37.000+02:00
The previous implementation of `replace` made it possible that formerly constrained
parameters would stay on embedded in bounds of other constraint enrties.
diff --git a/src/dotty/tools/dotc/core/OrderingConstraint.scala b/src/dotty/tools/dotc/core/OrderingConstraint.scala
@@ -419,7 +419,7 @@ class OrderingConstraint(private val boundsMap: ParamBounds,
           def replaceIn(tp: Type, isUpper: Boolean): Type = tp match {
             case `param` => normalize(replacement, isUpper)
             case tp: AndOrType if isUpper == tp.isAnd => recombine(tp, replaceIn, isUpper)
-            case _ => tp
+            case _ => tp.substParam(param, replacement)
           }
 
           bounds.derivedTypeBounds(replaceIn(lo, isUpper = false), replaceIn(hi, isUpper = true))

Original file line number	Diff line number	Diff line change
`@@ -419,7 +419,7 @@ class OrderingConstraint(private val boundsMap: ParamBounds,`
`419`	`419`	`def replaceIn(tp: Type, isUpper: Boolean): Type = tp match {`
`420`	`420`	case `param` => normalize(replacement, isUpper)
`421`	`421`	`case tp: AndOrType if isUpper == tp.isAnd => recombine(tp, replaceIn, isUpper)`
`422`		`- case _ => tp`
	`422`	`+ case _ => tp.substParam(param, replacement)`
`423`	`423`	`}`
`424`	`424`
`425`	`425`	`bounds.derivedTypeBounds(replaceIn(lo, isUpper = false), replaceIn(hi, isUpper = true))`