Fix #4661: Missing unreachable case warnings

Author: abeln

compiler/src/dotty/tools/dotc/transform/patmat/Space.scala

@@ -293,17 +293,22 @@ class SpaceEngine(implicit ctx: Context) extends SpaceLogic {
   private val nullSpace            = Typ(nullType)
 
   override def intersectUnrelatedAtomicTypes(tp1: Type, tp2: Type) = {
-    val and = AndType(tp1, tp2)
-    // Precondition: !(tp1 <:< tp2) && !(tp2 <:< tp1)
-    // Then, no leaf of the and-type tree `and` is a subtype of `and`.
-    val res = inhabited(and)
+    // Precondition: !isSubType(tp1, tp2) && !isSubType(tp2, tp1)
+    if (tp1 == nullType || tp2 == nullType) {
+      // Since projections of types don't include null, intersection with null is empty.
+      Empty
+    } else {
+      val and = AndType(tp1, tp2)
+      // Then, no leaf of the and-type tree `and` is a subtype of `and`.
+      val res = inhabited(and)
 
-    debug.println(s"atomic intersection: ${and.show} = ${res}")
+      debug.println(s"atomic intersection: ${and.show} = ${res}")
 
-    if (!res) Empty
-    else if (tp1.isSingleton) Typ(tp1, true)
-    else if (tp2.isSingleton) Typ(tp2, true)
-    else Typ(and, true)
+      if (!res) Empty
+      else if (tp1.isSingleton) Typ(tp1, true)
+      else if (tp2.isSingleton) Typ(tp2, true)
+      else Typ(and, true)
+    }
   }
 
   /** Whether the extractor is irrefutable */

tests/patmat/t4661.check

@@ -0,0 +1,3 @@
+9: Match case Unreachable
+10: Match case Unreachable
+11: Match case Unreachable

tests/patmat/t4661.scala

@@ -0,0 +1,13 @@
+trait Foo
+class One extends Foo
+class Two extends Foo
+class Three extends Foo
+
+object Test {
+  def test(f: Foo) = f match {
+    case f: Foo =>
+    case f: One =>
+    case f: Two =>
+    case f: Three =>
+  }
+}