Make ClassDenotation a trait

Author: odersky

compiler/src/dotty/tools/dotc/core/SymDenotations.scala

@@ -39,8 +39,8 @@ trait SymDenotations { this: Context =>
     initPrivateWithin: Symbol = NoSymbol)(implicit ctx: Context): SymDenotation = {
     val result =
       if (symbol.isClass)
-        if (initFlags is Package) new PackageClassDenotation(symbol, owner, name, initFlags, initInfo, initPrivateWithin)
-        else new ClassDenotation(symbol, owner, name, initFlags, initInfo, initPrivateWithin)
+        if (initFlags is Package) new SymDenotation(symbol, owner, name, initFlags, initInfo, initPrivateWithin) with PackageClassDenotation
+        else new SymDenotation(symbol, owner, name, initFlags, initInfo, initPrivateWithin) with ClassDenotation
       else new SymDenotation(symbol, owner, name, initFlags, initInfo, initPrivateWithin)
     result.validFor = stablePeriod
     result
@@ -1278,14 +1278,7 @@ object SymDenotations {
 
   /** The contents of a class definition during a period
    */
-  class ClassDenotation private[SymDenotations] (
-    symbol: Symbol,
-    maybeOwner: Symbol,
-    name: Name,
-    initFlags: FlagSet,
-    initInfo: Type,
-    initPrivateWithin: Symbol)
-    extends SymDenotation(symbol, maybeOwner, name, initFlags, initInfo, initPrivateWithin) {
+  trait ClassDenotation extends SymDenotation {
 
     import util.LRUCache
 
@@ -1351,8 +1344,8 @@ object SymDenotations {
 
     // ----- denotation fields and accessors ------------------------------
 
-    if (initFlags is (Module, butNot = Package))
-      assert(name.is(ModuleClassName), s"module naming inconsistency: ${name.debugString}")
+    //if (initFlags is (Module, butNot = Package))
+    //  assert(name.is(ModuleClassName), s"module naming inconsistency: ${name.debugString}")
 
     /** The symbol asserted to have type ClassSymbol */
     def classSymbol: ClassSymbol = symbol.asInstanceOf[ClassSymbol]
@@ -1804,14 +1797,7 @@ object SymDenotations {
   /** The denotation of a package class.
    *  It overrides ClassDenotation to take account of package objects when looking for members
    */
-  final class PackageClassDenotation private[SymDenotations] (
-    symbol: Symbol,
-    ownerIfExists: Symbol,
-    name: Name,
-    initFlags: FlagSet,
-    initInfo: Type,
-    initPrivateWithin: Symbol)
-    extends ClassDenotation(symbol, ownerIfExists, name, initFlags, initInfo, initPrivateWithin) {
+  trait PackageClassDenotation extends ClassDenotation {
 
     private[this] var packageObjCache: SymDenotation = _
     private[this] var packageObjRunId: RunId = NoRunId