Position inlined bindings correctly

milessabin · milessabin · commit 7c5dbcabd975 · 2018-12-19T10:47:18.000Z
diff --git a/compiler/src/dotty/tools/dotc/typer/Inliner.scala b/compiler/src/dotty/tools/dotc/typer/Inliner.scala
@@ -694,7 +694,7 @@ class Inliner(call: tpd.Tree, rhsToInline: tpd.Tree)(implicit ctx: Context) {
       	 */
         def newBinding(sym: TermSymbol, rhs: Tree): Unit = {
           sym.info = rhs.tpe.widenTermRefExpr
-          bindingsBuf += ValDef(sym, constToLiteral(rhs))
+          bindingsBuf += ValDef(sym, constToLiteral(rhs)).withPos(sym.pos)
         }
 
         def searchImplicit(sym: TermSymbol, tpt: Tree) = {
diff --git a/compiler/test/dotc/pos-test-pickling.blacklist b/compiler/test/dotc/pos-test-pickling.blacklist
@@ -1,8 +1,6 @@
 i1812.scala
 i1867.scala
 i3067.scala
-inline-rewrite.scala
-inline-caseclass.scala
 matchtype.scala
 seqtype-cycle
 t247.scala
diff --git a/compiler/test/dotc/run-test-pickling.blacklist b/compiler/test/dotc/run-test-pickling.blacklist
@@ -5,6 +5,4 @@ t3452g
 t7374
 tuples1.scala
 tuples1a.scala
-implicitMatch.scala
-typeclass-derivation1.scala
 typeclass-derivation2.scala

Original file line number	Diff line number	Diff line change
`@@ -694,7 +694,7 @@ class Inliner(call: tpd.Tree, rhsToInline: tpd.Tree)(implicit ctx: Context) {`
`694`	`694`	`*/`
`695`	`695`	`def newBinding(sym: TermSymbol, rhs: Tree): Unit = {`
`696`	`696`	`sym.info = rhs.tpe.widenTermRefExpr`
`697`		`- bindingsBuf += ValDef(sym, constToLiteral(rhs))`
	`697`	`+ bindingsBuf += ValDef(sym, constToLiteral(rhs)).withPos(sym.pos)`
`698`	`698`	`}`
`699`	`699`
`700`	`700`	`def searchImplicit(sym: TermSymbol, tpt: Tree) = {`