Skip to content

Commit 7a8f8d8

Browse files
committed
Enable pending pos tests related to value classes
Each test needs to have its own package because pos_all will try to compile the whole valueclasses directory at once. The remaining tests with "extends AnyVal" in tests/pending/pos are related to separate compilation, except for: - t6482.scala and t7022.scala which were fixed by scala/scala#1468 in scalac and seem to trigger a similar bug in FullParameterization - strip-tvars-for-lubbasetypes.scala which was fixed by scala/scala#1758 in scalac
1 parent a4ac989 commit 7a8f8d8

File tree

5 files changed

+11
-1
lines changed

5 files changed

+11
-1
lines changed

tests/pending/pos/optmatch.scala renamed to tests/pos/valueclasses/optmatch.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
1+
package optmatch
2+
13
// final case class NonZeroLong(value: Long) extends AnyVal {
24
// def get: Long = value
35
// def isEmpty: Boolean = get == 0l
46
// }
57

68
class NonZeroLong(val value: Long) extends AnyVal {
79
def get: Long = value
8-
def isEmpty: Boolean = get == 0l
10+
def isDefined: Boolean = get != 0l
911
}
1012
object NonZeroLong {
1113
def unapply(value: Long): NonZeroLong = new NonZeroLong(value)

tests/pending/pos/t5667.scala renamed to tests/pos/valueclasses/t5667.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
package t5667
2+
13
object Main {
24
implicit class C(val s: String) extends AnyVal
35
implicit class C2(val s: String) extends AnyRef

tests/pending/pos/t5953.scala renamed to tests/pos/valueclasses/t5953.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
package t5953
2+
13
import scala.collection.{ mutable, immutable, generic, GenTraversableOnce }
24

35
package object foo {

tests/pending/pos/t6260a.scala renamed to tests/pos/valueclasses/t6260a.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
package t6260a
2+
13
final class Option[+A](val value: A) extends AnyVal
24

35
// Was: sandbox/test.scala:21: error: bridge generated for member method f: ()Option[A] in class Bar

tests/pending/pos/t8011.scala renamed to tests/pos/valueclasses/t8011.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
package t8011
2+
13
class ThingOps1(val x: String) extends AnyVal {
24
def fn[A]: Any = {
35
new X[A] { def foo(a: A) = a }

0 commit comments

Comments
 (0)