Skip to content

Commit 7556fd5

Browse files
committed
Disable some flaky scalatest's tests
We usually don't notice these failures because the community build retries a project up to three times in case of failure, but sometimes all three of them fail, and even when it succeeds it means that community_build_a sometimes takes much longer than it needs to (2 hours instead of 1 hour). I'v reported this upstream at scalatest/scalatest#2049.
1 parent 0722bf4 commit 7556fd5

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

community-build/src/scala/dotty/communitybuild/projects.scala

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,19 @@ object projects:
278278

279279
lazy val scalatest: SbtCommunityProject = SbtCommunityProject(
280280
project = "scalatest",
281-
sbtTestCommand = "scalacticDotty/clean; scalacticDottyJS/clean; scalacticTestDotty/test; scalatestTestDotty/test; scalacticDottyJS/compile; scalatestDottyJS/compile",
281+
sbtTestCommand =
282+
List(
283+
"scalacticDotty/clean; scalacticDottyJS/clean",
284+
285+
// Some scalatest's tests are flaky (https://github.com/scalatest/scalatest/issues/2049)
286+
// so we disable them, this list is based on the one used in the Scala 2 community build
287+
// (https://github.com/scala/community-build/blob/2.13.x/proj/scalatest.conf).
288+
"""set scalatestTest / Test / unmanagedSources / excludeFilter := HiddenFileFilter || "GeneratorSpec.scala" || "FrameworkSuite.scala" || "WaitersSpec.scala" || "TestSortingReporterSpec.scala" || "JavaFuturesSpec.scala" || "ParallelTestExecutionSpec.scala" || "TimeLimitsSpec.scala" || "TestThreadsStartingCounterSpec.scala" || "SuiteSortingReporterSpec.scala" || "CommonGeneratorsSpec.scala" || "PropCheckerAssertingSpec.scala" || "ConductorMethodsSuite.scala"""",
289+
"""set scalacticTest / Test / unmanagedSources / excludeFilter := HiddenFileFilter || "NonEmptyArraySpec.scala"""",
290+
"""set genRegularTests4 / Test / managedSources ~= (_.filterNot(_.getName == "FrameworkSuite.scala").filterNot(_.getName == "GeneratorSpec.scala").filterNot(_.getName == "CommonGeneratorsSpec.scala").filterNot(_.getName == "ParallelTestExecutionSpec.scala").filterNot(_.getName == "DispatchReporterSpec.scala").filterNot(_.getName == "TestThreadsStartingCounterSpec.scala").filterNot(_.getName == "EventuallySpec.scala"))""",
291+
292+
"scalacticTestDotty/test; scalatestTestDotty/test; scalacticDottyJS/compile; scalatestDottyJS/compile"
293+
).mkString("; "),
282294
sbtPublishCommand = "scalacticDotty/publishLocal; scalatestDotty/publishLocal; scalacticDottyJS/publishLocal; scalatestDottyJS/publishLocal",
283295
sbtDocCommand = ";scalacticDotty/doc", // fails with missing type ;scalatestDotty/doc"
284296
// cannot take signature of (test: org.scalatest.concurrent.ConductorFixture#OneArgTest):

0 commit comments

Comments
 (0)