Skip to content

Commit 6aa24fa

Browse files
Only Ycheck scala2-library-bootstrapped once (#18732)
We only Ycheck the compilation of scala2-library-bootstrapped once. This test the -Yscala2-stdlib flag. We do this on the MiMa test to avoid the large overhead of Ycheck when compiling scala3-bootstrapped.
2 parents 44a537b + ff6c339 commit 6aa24fa

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

project/Build.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1009,7 +1009,6 @@ object Build {
10091009
},
10101010
Compile / doc / scalacOptions += "-Ydocument-synthetic-types",
10111011
scalacOptions += "-Ycompile-scala2-library",
1012-
scalacOptions += "-Ycheck:all",
10131012
scalacOptions -= "-Xfatal-warnings",
10141013
ivyConfigurations += SourceDeps.hide,
10151014
transitiveClassifiers := Seq("sources"),

project/scripts/scala2-library-tasty-mima.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ setTastyVersion $MINOR_TASTY_VERSION_SUPPORTED_BY_TASTY_MIMA 0
1717
# Run scala2-library-bootstrapped/tastyMiMaReportIssues using a custom TASTy version.
1818
# We clean before to make sure all sources are recompiled using the new TASTY version.
1919
# We clean after to make sure no other test will use the TASTy generated with this version.
20-
"$SBT" "clean; scala2-library-bootstrapped/clean; reload; scala2-library-bootstrapped/tastyMiMaReportIssues; clean; scala2-library-bootstrapped/clean"
20+
# We set -Ycheck:all to check that -Ycompile-scala2-library does not gererate inconsistent trees.
21+
"$SBT" 'clean; scala2-library-bootstrapped/clean; reload; set `scala2-library-bootstrapped`/scalacOptions += "-Ycheck:all"; scala2-library-bootstrapped/tastyMiMaReportIssues; clean; scala2-library-bootstrapped/clean'
2122

2223
setTastyVersion $MINOR_TASTY_VERSION $EXPERIMENTAL_TASTY_VERSION

0 commit comments

Comments
 (0)