Merge pull request #3609 from dotty-staging/fix-printer-args-format

nicolasstucki · web-flow · commit 668f1b794e6f · 2017-11-30T14:31:55.000+01:00
Do not print a space before arguments without flags
diff --git a/compiler/src/dotty/tools/dotc/printing/RefinedPrinter.scala b/compiler/src/dotty/tools/dotc/printing/RefinedPrinter.scala
@@ -269,7 +269,8 @@ class RefinedPrinter(_ctx: Context) extends PlainPrinter(_ctx) {
         else if (suppressKw) PrintableFlags &~ Private
         else PrintableFlags
       if (homogenizedView && mods.flags.isTypeFlags) flagMask &~= Implicit // drop implicit from classes
-      val flagsText = keywordStr((mods.flags & flagMask).toString)
+      val flags = mods.flags & flagMask
+      val flagsText = if (flags.isEmpty) "" else keywordStr((mods.flags & flagMask).toString)
       Text(mods.annotations.map(annotText), " ") ~~ flagsText ~~ (kw provided !suppressKw)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,8 @@ class RefinedPrinter(_ctx: Context) extends PlainPrinter(_ctx) {`
`269`	`269`	`else if (suppressKw) PrintableFlags &~ Private`
`270`	`270`	`else PrintableFlags`
`271`	`271`	`if (homogenizedView && mods.flags.isTypeFlags) flagMask &~= Implicit // drop implicit from classes`
`272`		`- val flagsText = keywordStr((mods.flags & flagMask).toString)`
	`272`	`+ val flags = mods.flags & flagMask`
	`273`	`+ val flagsText = if (flags.isEmpty) "" else keywordStr((mods.flags & flagMask).toString)`
`273`	`274`	`Text(mods.annotations.map(annotText), " ") ~~ flagsText ~~ (kw provided !suppressKw)`
`274`	`275`	`}`
`275`	`276`