Suppress redundant "recursive value needs type" messages

[Cherry-picked aa0df6c][modified]

Author: WojciechMazur

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -3102,7 +3102,7 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer
           case ex: CyclicReference
           if ctx.reporter.errorsReported
               && xtree.span.isZeroExtent
-              && ex.isVal && false =>
+              && ex.isVal =>
             // Don't report a "recursive val ... needs type" if errors were reported
             // previously and the span of the offending tree is empty. In this case,
             // it's most likely that this is desugared code, and the error message would

tests/neg/i18684.check

@@ -17,14 +17,8 @@
    |
    | longer explanation available when compiling with `-explain`
 -- [E127] Pattern Match Error: tests/neg/i18684.scala:12:6 -------------------------------------------------------------
-12 |  val inner(x) = 3 // error // error
+12 |  val inner(x) = 3 // error
    |      ^^^^^
    |      Test.inner cannot be used as an extractor in a pattern because it lacks an unapply or unapplySeq method
    |
    | longer explanation available when compiling with `-explain`
--- [E045] Cyclic Error: tests/neg/i18684.scala:12:14 -------------------------------------------------------------------
-12 |  val inner(x) = 3 // error // error
-   |              ^
-   |              Recursive value x needs type
-   |
-   | longer explanation available when compiling with `-explain`

tests/neg/i18684.scala

@@ -9,4 +9,4 @@ object Test:
   object inner:
     val foo() = "33" // error
 
-  val inner(x) = 3 // error // error
+  val inner(x) = 3 // error

tests/neg/t5702-neg-bad-and-wild.check

@@ -27,7 +27,7 @@
    |
    | longer explanation available when compiling with `-explain`
 -- [E032] Syntax Error: tests/neg/t5702-neg-bad-and-wild.scala:23:17 ---------------------------------------------------
-23 |    val K(ns @ _*, xx) = k // error: pattern expected // error
+23 |    val K(ns @ _*, xx) = k // error: pattern expected
    |                 ^
    |                 pattern expected
    |
@@ -50,12 +50,6 @@
    |                    no pattern match extractor named * was found
    |
    | longer explanation available when compiling with `-explain`
--- [E045] Cyclic Error: tests/neg/t5702-neg-bad-and-wild.scala:23:19 ---------------------------------------------------
-23 |    val K(ns @ _*, xx) = k // error: pattern expected // error
-   |                   ^
-   |                   Recursive value $1$ needs type
-   |
-   | longer explanation available when compiling with `-explain`
 -- Warning: tests/neg/t5702-neg-bad-and-wild.scala:13:22 ---------------------------------------------------------------
 13 |      case List(1, _*3:) =>  // error // error
    |                      ^

tests/neg/t5702-neg-bad-and-wild.scala

@@ -20,7 +20,7 @@ object Test {
 // good syntax, bad semantics, detected by typer
 //gowild.scala:14: error: star patterns must correspond with varargs parameters
     val K(x @ _*) = k
-    val K(ns @ _*, xx) = k // error: pattern expected // error
+    val K(ns @ _*, xx) = k // error: pattern expected
     val K(x) = k // error: x is already defined as value x
     val (b, _ * ) = (5,6) // ok
 // no longer complains